Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

SelectChain implementation for relay chains #3341

Merged
merged 12 commits into from
Jun 22, 2021
Merged

Conversation

rphmeier
Copy link
Contributor

Based on the new ChainSelectionSubsystem introduced in #3277, this implements a SelectChain implementation known as RelaySelectChain.

RelaySelectChain is intended to replace the ApprovalCheckingVotingRule by its implementation of fn finality_target, which will draw from the dispute coordinator in the future. I've also introduced a notion of OverseerHandlers being disconnected, which means that they are connected to no underlying overseer. This is necessary for when we actually integrate the RelaySelectChain in the service because it serves 2 purposes:

  1. The control flow of the service requires the SelectChain to be instantiated before the creation of the overseer. This lets us create the SelectChain instance and activate it later.
  2. A RelaySelectChain which is disconnected from the overseer will always fall back to a LongestChain fork-choice rule. This will be useful for Polkadot until parachains are launched, in the same vein as disable approval-checking voting rule on polkadot #3321 .

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 22, 2021
@github-actions github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jun 22, 2021
@rphmeier rphmeier added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 22, 2021
@rphmeier rphmeier marked this pull request as ready for review June 22, 2021 18:52
@rphmeier rphmeier merged commit 6331c25 into master Jun 22, 2021
@rphmeier rphmeier deleted the rh-chain-selection-wrapper branch June 22, 2021 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants