This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dispute coordinator overlay #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of moving to the overlayed backend pattern, this commit moves the db to return SubsystemResult values.
This commit adds the backend and overlayed backend structs to the dispute-coordinator subsystem.
This commit finalizes the move from the previous transactional model to the common overlay pattern in subsystem persistency. This can be observed in the ApprovalVoting and ChainSelection subsystems.
Lldenaurois
added
A0-please_review
rphmeier
reviewed
Jul 12, 2021
| @@ -0,0 +1,160 @@ | |||
| use polkadot_primitives::v1::{CandidateHash, SessionIndex}; | |||
There was a problem hiding this comment.
License header & module docs, please
rphmeier
approved these changes
Jul 13, 2021
|
Looks good! Needs another merge; last one must have missed something. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves the dispute coordinator to the common Backend, OverlayedBackend pattern used in both the Approval Voting and Chain Selection subsystems.