This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Dispute coordinator overlay #3462
Merged
Lldenaurois
merged 6 commits into
paritytech:master
from
Lldenaurois:dispute-coordinator-overlay
Jul 13, 2021
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2c1dd30
node/dispute-coordinator: Modify db to return SubsystemResult.
Lldenaurois 67674db
node/dispute-coordinator: Add the Backend and OverlayedBackend.
Lldenaurois f3f0cb8
node/dispute-coordinator: Implement backend and overlayed-backend.
Lldenaurois ced0b5c
Add module docs + license
Lldenaurois f9da7d5
Merge remote-tracking branch 'origin/master' into dispute-coordinator…
Lldenaurois ebe2cb1
Touchup merge
Lldenaurois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,183 @@ | ||
// Copyright 2020 Parity Technologies (UK) Ltd. | ||
// This file is part of Polkadot. | ||
|
||
// Polkadot is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Polkadot is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
//! An abstraction over storage used by the chain selection subsystem. | ||
//! | ||
//! This provides both a [`Backend`] trait and an [`OverlayedBackend`] | ||
//! struct which allows in-memory changes to be applied on top of a | ||
//! [`Backend`], maintaining consistency between queries and temporary writes, | ||
//! before any commit to the underlying storage is made. | ||
|
||
use polkadot_primitives::v1::{CandidateHash, SessionIndex}; | ||
use polkadot_node_subsystem::SubsystemResult; | ||
|
||
use std::collections::HashMap; | ||
|
||
use super::db::v1::{RecentDisputes, CandidateVotes}; | ||
|
||
#[derive(Debug)] | ||
pub enum BackendWriteOp { | ||
WriteEarliestSession(SessionIndex), | ||
WriteRecentDisputes(RecentDisputes), | ||
WriteCandidateVotes(SessionIndex, CandidateHash, CandidateVotes), | ||
DeleteCandidateVotes(SessionIndex, CandidateHash), | ||
} | ||
|
||
/// An abstraction over backend storage for the logic of this subsystem. | ||
pub trait Backend { | ||
/// Load the earliest session, if any. | ||
fn load_earliest_session(&self) -> SubsystemResult<Option<SessionIndex>>; | ||
|
||
/// Load the recent disputes, if any. | ||
fn load_recent_disputes(&self) -> SubsystemResult<Option<RecentDisputes>>; | ||
|
||
/// Load the candidate votes for the specific session-candidate pair, if any. | ||
fn load_candidate_votes( | ||
&self, | ||
session: SessionIndex, | ||
candidate_hash: &CandidateHash, | ||
) -> SubsystemResult<Option<CandidateVotes>>; | ||
|
||
/// Atomically writes the list of operations, with later operations taking precedence over | ||
/// prior. | ||
fn write<I>(&mut self, ops: I) -> SubsystemResult<()> | ||
where I: IntoIterator<Item = BackendWriteOp>; | ||
} | ||
|
||
/// An in-memory overllay for the backend. | ||
/// | ||
/// This maintains read-only access to the underlying backend, but can be converted into a set of | ||
/// write operations which will, when written to the underlying backend, give the same view as the | ||
/// state of the overlay. | ||
pub struct OverlayedBackend<'a, B: 'a> { | ||
inner: &'a B, | ||
|
||
// `None` means unchanged. | ||
earliest_session: Option<SessionIndex>, | ||
// `None` means unchanged. | ||
recent_disputes: Option<RecentDisputes>, | ||
// `None` means deleted, missing means query inner. | ||
candidate_votes: HashMap<(SessionIndex, CandidateHash), Option<CandidateVotes>>, | ||
} | ||
|
||
impl<'a, B: 'a + Backend> OverlayedBackend<'a, B> { | ||
pub fn new(backend: &'a B) -> Self { | ||
Self { | ||
inner: backend, | ||
earliest_session: None, | ||
recent_disputes: None, | ||
candidate_votes: HashMap::new(), | ||
} | ||
} | ||
|
||
/// Returns true if the are no write operations to perform. | ||
pub fn is_empty(&self) -> bool { | ||
self.earliest_session.is_none() && | ||
self.recent_disputes.is_none() && | ||
self.candidate_votes.is_empty() | ||
} | ||
|
||
/// Load the earliest session, if any. | ||
pub fn load_earliest_session(&self) -> SubsystemResult<Option<SessionIndex>> { | ||
if let Some(val) = self.earliest_session { | ||
return Ok(Some(val)) | ||
} | ||
|
||
self.inner.load_earliest_session() | ||
} | ||
|
||
/// Load the recent disputes, if any. | ||
pub fn load_recent_disputes(&self) -> SubsystemResult<Option<RecentDisputes>> { | ||
if let Some(val) = &self.recent_disputes { | ||
return Ok(Some(val.clone())) | ||
} | ||
|
||
self.inner.load_recent_disputes() | ||
} | ||
|
||
/// Load the candidate votes for the specific session-candidate pair, if any. | ||
pub fn load_candidate_votes( | ||
&self, | ||
session: SessionIndex, | ||
candidate_hash: &CandidateHash | ||
) -> SubsystemResult<Option<CandidateVotes>> { | ||
if let Some(val) = self.candidate_votes.get(&(session, *candidate_hash)) { | ||
return Ok(val.clone()) | ||
} | ||
|
||
self.inner.load_candidate_votes(session, candidate_hash) | ||
} | ||
|
||
/// Prepare a write to the 'earliest session' field of the DB. | ||
/// | ||
/// Later calls to this function will override earlier ones. | ||
pub fn write_earliest_session(&mut self, session: SessionIndex) { | ||
self.earliest_session = Some(session); | ||
} | ||
|
||
/// Prepare a write to the recent disputes stored in the DB. | ||
/// | ||
/// Later calls to this function will override earlier ones. | ||
pub fn write_recent_disputes(&mut self, recent_disputes: RecentDisputes) { | ||
self.recent_disputes = Some(recent_disputes) | ||
} | ||
|
||
/// Prepare a write of the candidate votes under the indicated candidate. | ||
/// | ||
/// Later calls to this function for the same candidate will override earlier ones. | ||
pub fn write_candidate_votes( | ||
&mut self, | ||
session: SessionIndex, | ||
candidate_hash: CandidateHash, | ||
votes: CandidateVotes | ||
) { | ||
self.candidate_votes.insert((session, candidate_hash), Some(votes)); | ||
} | ||
|
||
/// Prepare a deletion of the candidate votes under the indicated candidate. | ||
/// | ||
/// Later calls to this function for the same candidate will override earlier ones. | ||
pub fn delete_candidate_votes( | ||
&mut self, | ||
session: SessionIndex, | ||
candidate_hash: CandidateHash, | ||
) { | ||
self.candidate_votes.insert((session, candidate_hash), None); | ||
} | ||
|
||
/// Transform this backend into a set of write-ops to be written to the inner backend. | ||
pub fn into_write_ops(self) -> impl Iterator<Item = BackendWriteOp> { | ||
let earliest_session_ops = self.earliest_session | ||
.map(|s| BackendWriteOp::WriteEarliestSession(s)) | ||
.into_iter(); | ||
|
||
let recent_dispute_ops = self.recent_disputes | ||
.map(|d| BackendWriteOp::WriteRecentDisputes(d)) | ||
.into_iter(); | ||
|
||
let candidate_vote_ops = self.candidate_votes | ||
.into_iter() | ||
.map(|((session, candidate), votes)| match votes { | ||
Some(votes) => BackendWriteOp::WriteCandidateVotes(session, candidate, votes), | ||
None => BackendWriteOp::DeleteCandidateVotes(session, candidate), | ||
}); | ||
|
||
earliest_session_ops | ||
.chain(recent_dispute_ops) | ||
.chain(candidate_vote_ops) | ||
|
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License header & module docs, please