v0.9.11-rc4 #4027

s3krit · 2021-10-06T15:28:41Z

Update weights
Backport Allow an Offset to Lease Periods #3980
Backport Polkadot: Remove configuration's runtime migration and just set StorageVersion #4035

chevdor · 2021-10-06T15:40:06Z

runtime/kusama/src/weights/pallet_im_online.rs

-			.saturating_add((347_000 as Weight).saturating_mul(e as Weight))
+			.saturating_add((168_000 as Weight).saturating_mul(k as Weight))
+			// Standard Error: 4_000
+			.saturating_add((768_000 as Weight).saturating_mul(e as Weight))


Significant increase

chevdor · 2021-10-06T15:45:27Z

runtime/kusama/src/weights/pallet_scheduler.rs

+	fn cancel(s: u32, ) -> Weight {
+		(24_455_000 as Weight)
+			// Standard Error: 7_000
+			.saturating_add((1_849_000 as Weight).saturating_mul(s as Weight))


Significant decrease

chevdor · 2021-10-06T15:45:45Z

runtime/kusama/src/weights/pallet_scheduler.rs

+	fn cancel_named(s: u32, ) -> Weight {
+		(26_842_000 as Weight)
+			// Standard Error: 9_000
+			.saturating_add((1_880_000 as Weight).saturating_mul(s as Weight))


Significant decrease

chevdor · 2021-10-06T15:46:39Z

runtime/kusama/src/weights/pallet_staking.rs

-		(2_809_466_000 as Weight)
-			// Standard Error: 181_000
-			.saturating_add((16_204_000 as Weight).saturating_mul(s as Weight))
+		(6_584_935_000 as Weight)


Significant 📈

shawntabrizi · 2021-10-06T15:52:53Z

/benchmark runtime kusama pallet_scheduler

parity-benchapp · 2021-10-06T15:52:55Z

Error running benchmark: mp-v0.9.11-weights

stdout

From https://github.com/paritytech/polkadot * branch master -> FETCH_HEAD f520483..a14bdf1 master -> origin/master

chevdor · 2021-10-06T15:54:36Z

runtime/kusama/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_locked(l: u32, s: u32, ) -> Weight {
+		(45_931_000 as Weight)


significant 📉

chevdor · 2021-10-06T15:54:53Z

runtime/kusama/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_unlocked(l: u32, s: u32, ) -> Weight {
+		(45_326_000 as Weight)


significant 📉

chevdor · 2021-10-06T15:55:18Z

runtime/kusama/src/weights/pallet_vesting.rs

+	// Storage: Balances Locks (r:1 w:1)
+	// Storage: System Account (r:1 w:1)
+	fn vest_other_unlocked(l: u32, s: u32, ) -> Weight {
+		(45_906_000 as Weight)


significant 📉 + others around the vestedcalls

chevdor · 2021-10-06T15:57:02Z

runtime/kusama/src/weights/runtime_common_paras_registrar.rs

 	fn register() -> Weight {
-		(4_193_117_000 as Weight)
+		(8_869_444_000 as Weight)


significant 📈 (+1 below)

chevdor · 2021-10-06T15:57:19Z

runtime/kusama/src/weights/runtime_common_slots.rs

 	fn force_lease() -> Weight {
-		(92_502_000 as Weight)
+		(44_857_000 as Weight)


significant 📉

chevdor · 2021-10-06T16:02:17Z

runtime/polkadot/src/weights/pallet_im_online.rs

-			.saturating_add((328_000 as Weight).saturating_mul(e as Weight))
+			.saturating_add((166_000 as Weight).saturating_mul(k as Weight))
+			// Standard Error: 3_000
+			.saturating_add((722_000 as Weight).saturating_mul(e as Weight))


significant 📈

chevdor

I spotted a few noticeable to ♾ going from 0 to a few millions.
The big changes should be checked. There are especially quick some in the vesting pallet

chevdor · 2021-10-06T16:12:25Z

runtime/polkadot/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_locked(l: u32, s: u32, ) -> Weight {
+		(45_502_000 as Weight)


significant 📉

chevdor · 2021-10-06T16:12:43Z

runtime/polkadot/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_unlocked(l: u32, s: u32, ) -> Weight {
+		(45_054_000 as Weight)


significant 📉

chevdor · 2021-10-06T16:13:30Z

runtime/polkadot/src/weights/pallet_vesting.rs

+	// Storage: Balances Locks (r:1 w:1)
+	// Storage: System Account (r:1 w:1)
+	fn vest_other_locked(l: u32, s: u32, ) -> Weight {
+		(45_957_000 as Weight)


significant 📉 on vest*

chevdor · 2021-10-06T16:15:49Z

runtime/polkadot/src/weights/runtime_common_slots.rs

 	fn force_lease() -> Weight {
-		(92_502_000 as Weight)
+		(41_290_000 as Weight)


significant 📉

chevdor · 2021-10-06T16:32:11Z

runtime/westend/src/weights/pallet_utility.rs

+	fn batch(c: u32, ) -> Weight {
+		(20_055_000 as Weight)
+			// Standard Error: 3_000
+			.saturating_add((7_234_000 as Weight).saturating_mul(c as Weight))


significant 📈

chevdor · 2021-10-06T16:32:22Z

runtime/westend/src/weights/pallet_utility.rs

+	fn batch_all(c: u32, ) -> Weight {
+		(22_129_000 as Weight)
+			// Standard Error: 3_000
+			.saturating_add((7_909_000 as Weight).saturating_mul(c as Weight))


significant 📈

chevdor · 2021-10-06T16:32:34Z

runtime/westend/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_locked(l: u32, s: u32, ) -> Weight {
+		(45_631_000 as Weight)


significant 📉

chevdor · 2021-10-06T16:33:01Z

runtime/westend/src/weights/pallet_vesting.rs

+	// Storage: Vesting Vesting (r:1 w:1)
+	// Storage: Balances Locks (r:1 w:1)
+	fn vest_unlocked(l: u32, s: u32, ) -> Weight {
+		(45_068_000 as Weight)


significant 📉 again for all the vest*

chevdor · 2021-10-06T16:34:02Z

runtime/westend/src/weights/runtime_common_crowdloan.rs

-			.saturating_add((44_792_000 as Weight).saturating_mul(k as Weight))
+	// Storage: Skipped Metadata (r:0 w:0)
+	fn refund(k: u32, ) -> Weight {
+		(42_888_000 as Weight)


BIGGGGG 📈 ♾

chevdor · 2021-10-06T16:37:53Z

runtime/westend/src/weights/runtime_common_paras_registrar.rs

 	fn register() -> Weight {
-		(4_178_287_000 as Weight)
-			.saturating_add(T::DbWeight::get().reads(5 as Weight))
+		(7_233_188_000 as Weight)


significant 📈

* add slot offset for slots * trying things out * fix test * improve api to return the first block of a new lease period * add an integration test with offset * de-duplicate test * hide lease period_period_length from public api * fix benchmarks * Update runtime/common/src/slots.rs * support the exact same range of crowdloans * fix docs * fix docs again * introduce offset to runtimes * fix and check edge case w/ offset and lease period first block * remove newline * turn into an option * fix benchmarks Co-authored-by: Robert Habermeier <rphmeier@gmail.com>

…geVersion (#4035) * wip * Remove unused members

v0.9.11 weights

7488aa1

s3krit requested review from chevdor and shawntabrizi October 6, 2021 15:28

chevdor reviewed Oct 6, 2021

View reviewed changes

s3krit changed the title ~~v0.9.11 weights~~ v0.9.11-rc4 Oct 7, 2021

Polkadot: Remove configuration's runtime migration and just set Stora…

c434c24

…geVersion (#4035) * wip * Remove unused members

s3krit merged commit bfd38ed into release-v0.9.11 Oct 7, 2021

s3krit deleted the mp-v0.9.11-weights branch October 7, 2021 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.9.11-rc4 #4027

v0.9.11-rc4 #4027

s3krit commented Oct 6, 2021 •

edited

Loading

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021 •

edited

Loading

shawntabrizi commented Oct 6, 2021

parity-benchapp bot commented Oct 6, 2021 •

edited

Loading

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021 •

edited

Loading

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor left a comment

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

chevdor Oct 6, 2021

v0.9.11-rc4 #4027

v0.9.11-rc4 #4027

Conversation

s3krit commented Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chevdor Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

shawntabrizi commented Oct 6, 2021

parity-benchapp bot commented Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chevdor Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chevdor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s3krit commented Oct 6, 2021 •

edited

Loading

chevdor Oct 6, 2021 •

edited

Loading

parity-benchapp bot commented Oct 6, 2021 •

edited

Loading

chevdor Oct 6, 2021 •

edited

Loading