This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Polkadot: Remove configuration's runtime migration and just set StorageVersion #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A0-please_review
bkchr
approved these changes
Oct 7, 2021
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
s3krit
pushed a commit
that referenced
this pull request
Oct 7, 2021
…geVersion (#4035) * wip * Remove unused members
Merged
s3krit
added a commit
that referenced
this pull request
Oct 7, 2021
* v0.9.11 weights * Allow an Offset to Lease Periods (#3980) * add slot offset for slots * trying things out * fix test * improve api to return the first block of a new lease period * add an integration test with offset * de-duplicate test * hide lease period_period_length from public api * fix benchmarks * Update runtime/common/src/slots.rs * support the exact same range of crowdloans * fix docs * fix docs again * introduce offset to runtimes * fix and check edge case w/ offset and lease period first block * remove newline * turn into an option * fix benchmarks Co-authored-by: Robert Habermeier <rphmeier@gmail.com> * Polkadot: Remove configuration's runtime migration and just set StorageVersion (#4035) * wip * Remove unused members Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Robert Habermeier <rphmeier@gmail.com> Co-authored-by: Sergei Shulepov <sergei@parity.io>
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
…geVersion (#4035) * wip * Remove unused members
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the runtime storage migration for parachain's configuration module. At the moment of writing, the migration was introduced by #3575 and is already in pipeline for Kusama.
For Polkadot we do not need to perform the migration. However, we do need to update the StorageVersion to sync it with the Kusama's one.