This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
introduce malus + zombienet based integration tests #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @drahnr, thanks for the review and suggestions :) . I pushed all the changes. |
drahnr
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Looks good to me, I'd like to get a second pair of changes on the changeset, it's rather large (we really need stacked PRs)
Technically we are only using one malus variant right now, so we could remove the others and introduce them in a later PR, where @Lldenaurois could merge them with the functional parts of #3783
|
Also: the integration test seems to fail now |
ordian
reviewed
Nov 19, 2021
|
Almost :) missing a format run with the right nightly compiler version |
|
Yes, I will run fmt later today and ping you again. Thanks for your help!
🙌
…On Sat, 20 Nov 2021 at 12:19 Bernhard Schuster ***@***.***> wrote:
Almost :) missing a format run with the right nightly compiler version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACY3B764XJROAWA7ZKWBKDUM572ZANCNFSM5GQXJ7HQ>
.
|
* master: (38 commits) Replicate Rob's PR (#4337) Companion for Taskmanager: Remove `clean_shutdown` (#4336) prefer code upgrades in inherent filtering (#4334) remove provisioner checks (#4254) Log para inherent inputs (#4331) Dispute spam protection (#4134) Dependabot: Ignore sub-tokens (#4328) export hrmp config (#4324) Add missing license header (#4321) Use non-empty validation code (#4322) fix pallet-xcm extrinsic doc comments (#4317) prepare worker: Catch unexpected unwinds (#4304) Enable BEEFY explicitly (#4320) Bump serde_json from 1.0.70 to 1.0.71 (#4316) Bump strum from 0.22.0 to 0.23.0 (#4308) Remove sort_unstable_by (#4314) Bump tokio from 1.13.0 to 1.14.0 (#4298) Substrate companion: Authority discovery multiple peer ids (#4295) Companion for substrate#9878 (#3949) move paras inherent filtering to runtime (#4028) ...
ordian
approved these changes
Nov 20, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for d3d5b5f |
|
bot merge |
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds zombie-net based integration test, based on
bernhard-malus-fxbranch originally based onsimnet.Enables a simple (
0001!) test that provides a smoke test for disputes as part of our CI runs.