Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump pwasm-utils to 0.18.2 #4267

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Bump pwasm-utils to 0.18.2 #4267

merged 1 commit into from
Nov 12, 2021

Conversation

pepyakin
Copy link
Contributor

Mainly to incorporate this change paritytech/wasm-utils#170 which affect the deterministic stack limit injection performance.

deterministic_stack_limit: Some(DeterministicStackLimit {

@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 12, 2021
@@ -11122,7 +11122,7 @@ version = "1.6.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1f559b464de2e2bdabcac6a210d12e9b5a5973c251e102c44c585c71d51bd78e"
dependencies = [
"cfg-if 1.0.0",
"cfg-if 0.1.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/cargo#5702 in case you're wondering why

it is also possible to revert manually, but I'm not sure if it's worth it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, good catch! Let me try to revert that

Copy link
Contributor Author

@pepyakin pepyakin Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, on the second thought we already have lots of 0.1.10 (maybe for the same reason) so not sure if it's worth it as well

@bkchr
Copy link
Member

bkchr commented Nov 12, 2021

I would like to see this on Substrate to "force" everybody to get this update.

@pepyakin
Copy link
Contributor Author

You mean in addition to here?

@bkchr
Copy link
Member

bkchr commented Nov 12, 2021

If you bump the version in the sc-executor Cargo.toml, you will get this pr here for "free" when Substrate is updated :P

@pepyakin pepyakin added this to the v0.9.13 milestone Nov 12, 2021
@ordian ordian merged commit db10793 into master Nov 12, 2021
@ordian ordian deleted the pep-update-pwasm-utils branch November 12, 2021 17:16
drahnr pushed a commit that referenced this pull request Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants