This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
Use linear time algorithm to inject stack height metering #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current algorithm to inject the preamble and postamble for
call
instructions has quadratic complexity:This is because the
splice
function needs to copy around theVec
of instructions for everycall
instruction. A function can consist of only calls. This was evident when experimenting with different benchmarks. This PR replaces this by a linear algorithm. The benchmark in question went from 20secs to 1sec runtime.Please note that leaving this unfixed is a DoS vector when the stack height metering is applied to untrusted code.