Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

runtime/polkadot: enable disputes rewards and slashing #6960

Merged
merged 3 commits into from
May 3, 2023
Merged

runtime/polkadot: enable disputes rewards and slashing #6960

merged 3 commits into from
May 3, 2023

Conversation

ordian
Copy link
Member

@ordian ordian commented Mar 27, 2023 •
edited
Loading

Same as #5974, but for polkadot.

Slashing is only for "ForInvalid" disputes, which we haven't seen yet.

@ordian ordian added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. S5-on_ice Work is currently on hold, see comments for further information. T1-runtime This PR/Issue is related to the topic “runtime”. B1-note_worthy Changes should be noted in the release notes labels Mar 27, 2023
@ordian
Copy link
Member Author

ordian commented Mar 27, 2023

bot bench $ runtime polkadot runtime_parachains::disputes::slashing

@command-bot
Copy link

command-bot bot commented Mar 27, 2023 •
edited
Loading

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::disputes::slashing was queued.

Comment bot cancel 49-89deed10-19e4-4786-b662-0bbb352eb4e2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 27, 2023

@ordian Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::disputes::slashing has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

@ordian
Copy link
Member Author

ordian commented Mar 27, 2023

bot bench $ runtime polkadot runtime_parachains::disputes::slashing

@command-bot
Copy link

command-bot bot commented Mar 27, 2023 •
edited
Loading

@ordian https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2594473 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::disputes::slashing. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 53-111fe18b-7c57-4a26-a699-1bf812716a38 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 27, 2023

@ordian Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::disputes::slashing has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2594473 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2594473/artifacts/download.

@eskimor eskimor mentioned this pull request Mar 27, 2023
Open
14 tasks
@ordian ordian marked this pull request as ready for review April 11, 2023 12:41
@paritytech-ci paritytech-ci requested review from a team April 11, 2023 12:42
@ordian
Merge branch 'master' into ao-polkadot-enable-dispute-slashing
de707de 
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
@ordian ordian removed the S5-on_ice Work is currently on hold, see comments for further information. label Apr 11, 2023
@ordian ordian requested a review from eskimor April 11, 2023 13:12
BradleyOlson64
BradleyOlson64 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@BradleyOlson64 BradleyOlson64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing amiss 👍

@paritytech-ci paritytech-ci requested a review from a team April 11, 2023 19:38
@ordian ordian requested a review from bkchr April 14, 2023 12:04
@ordian
Copy link
Member Author

ordian commented May 3, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 3bf3a99 into master May 3, 2023
@paritytech-processbot paritytech-processbot bot deleted the ao-polkadot-enable-dispute-slashing branch May 3, 2023 13:48
@ordian ordian mentioned this pull request Jun 6, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@coderobe coderobe coderobe approved these changes

@bkchr bkchr bkchr approved these changes

@eskimor eskimor eskimor approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ordian @tdimitrov @eskimor @bkchr @coderobe @BradleyOlson64