Added pagination 📑 for listReviews 👥 endpoint
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to experiment between releases
rzadp
approved these changes
Nov 29, 2023
It seems there are more fellows so the test takes more time. I also moved the timeout to the fellows tests so it doesn't extend the timeout in other tests that work properly with the shorter one
Bullrich
force-pushed
the
review-pagination
branch
from
ed14629 to
002a1d8
Compare
Merged
Bullrich
added a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the pagination method when fetching reviews, as the default endpoint has a hard limit of 30 results. By adding pagination we can go over the limit of 30.
Fixes #102