Added more details in the rule output #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can know what approvals counted towards a rule
This way it is better shown for people who care about the rule logic
Merged
rzadp
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added detailed explanation in the rules output, informing how each rule works and a list of approvals that counts towards incomplete rules (so we can see who's review count where).
Resolves #103
Example of rule output:
Details per rule:
Core developers
Missing 1 review
Rule explanation
Rule 'Basic' requires a given amount of reviews from users/teamsFor more info found out how the rules work in Review-bot types
Missing reviews from teams
Users approvals that counted towards this rule
Runtime files cumulus
Missing 2 reviews
Rule explanation
Rule 'And Distinct' has many required reviewers/teams and requires all of them to be fulfilled **by different users**.The approval of one user that belongs to two teams will count only towards one team.
For more info found out how the rules work in Review-bot types
Missing reviews from teams
Users approvals that counted towards this rule