Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

New Pallet: Root offences #11943

Merged
merged 61 commits into from
Sep 28, 2022
Merged

New Pallet: Root offences #11943

merged 61 commits into from
Sep 28, 2022

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Jul 31, 2022 •
edited
Loading

Closes #11352

Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

@Szegoo Szegoo marked this pull request as ready for review August 1, 2022 09:59
@Szegoo
Copy link
Contributor Author

Szegoo commented Aug 1, 2022 •
edited
Loading

@kianenigma Could you take a look and check if I am on the right path with this? I am not done here, but before I continue I just want to make sure that I am not doing something wrong here.

KiChjang
KiChjang reviewed Aug 13, 2022
View reviewed changes
frame/system/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1745227

kianenigma
kianenigma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kianenigma
Copy link
Contributor

/tip large

Szegoo and others added 3 commits September 26, 2022 16:17
@Szegoo @kianenigma
Update frame/root-offences/src/lib.rs
7b6d8ef 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@Szegoo @kianenigma
Update frame/root-offences/src/lib.rs
7a79785 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@Szegoo
docs
4838575
@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 26, 2022

/tip large

@kianenigma Hmm, this didn't work :/

@kianenigma
Copy link
Contributor

/tip large

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 26, 2022

/tip large

@kianenigma Not sure why the tip command isn't working.

ordian
ordian approved these changes Sep 27, 2022
View reviewed changes
frame/root-offences/README.md Outdated Show resolved Hide resolved
frame/root-offences/src/mock.rs Show resolved Hide resolved
frame/root-offences/src/tests.rs Show resolved Hide resolved
frame/root-offences/Cargo.toml Outdated Show resolved Hide resolved
Szegoo and others added 3 commits September 27, 2022 15:15
@Szegoo @ordian
Update frame/root-offences/README.md
6de5482 
Co-authored-by: Andronik <write@reusable.software>
@Szegoo @ordian
Update frame/root-offences/Cargo.toml
64ab683 
Co-authored-by: Andronik <write@reusable.software>
@Szegoo
license header
83ff690
@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 28, 2022

@kianenigma I think we can merge this now :)

@ordian
Copy link
Member

ordian commented Sep 28, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 96de768 into paritytech:master Sep 28, 2022
@kianenigma
Copy link
Contributor

/tip large

@kianenigma
Copy link
Contributor

\tip large

@kianenigma
Copy link
Contributor

@Szegoo the tip bot is currently down. If I forget, please remind me again and I will make sure it happens. You can reach out to @kianenigma:matrix.parity.io or kian@parity.io.

@shawntabrizi
Copy link
Member

/tip large

2 similar comments
@kianenigma
Copy link
Contributor

/tip large

@mordamax
Copy link
Contributor

/tip large

@substrate-tip-bot
Copy link

@mordamax You are not allowed to request a tip. Only shawntabrizi, gavofyork, rphmeier, athei, andresilva, arkpar, bkchr, eskimor, drahnr, dvdplm, robbepop, cmichi, tomaka, pepyakin, tomusdrw, kianenigma, jacogr, rossbulat are allowed.

@shawntabrizi
Copy link
Member

/tip large

@substrate-tip-bot
Copy link

@shawntabrizi A large tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

@Szegoo
Copy link
Contributor Author

Szegoo commented Sep 29, 2022

Thanks!

ordian added a commit that referenced this pull request Oct 5, 2022
@ordian
Merge branch 'master' into ao-update-kvdb-and-co
bd29c35 
* master: (42 commits)
  Adapt `pallet-contracts` to WeightV2 (#12421)
  Improved election pallet testing (#12327)
  Bump prost to 0.11+ (#12419)
  Use saturating add for alliance::disband witness data (#12418)
  [Fix] Rename VoterBagsList -> VoterList to match pdot (#12416)
  client/beefy: small code improvements (#12414)
  BEEFY: Simplify hashing for pallet-beefy-mmr (#12393)
  Add @koute to `docs/CODEOWNERS` and update stale paths (#12408)
  docs/CODEOWNERS: add @acatangiu as MMR owner (#12406)
  Remove unnecessary Clone trait bounds on CountedStorageMap (#12402)
  Fix `Weight::is_zero` (#12396)
  Beefy on-demand justifications as a custom RequestResponse protocol (#12124)
  Remove contracts RPCs (#12358)
  pallet-mmr: generate historical proofs (#12324)
  unsafe_pruning flag removed (#12385)
  Carry over where clauses defined in Config to Call and Hook (#12388)
  Properly set the max proof size weight on defaults and tests (#12383)
  BEEFY: impl TypeInfo for SignedCommitment (#12382)
  bounding staking: `BoundedElectionProvider` trait (#12362)
  New Pallet: Root offences (#11943)
  ...
@Szegoo Szegoo mentioned this pull request Oct 7, 2022
Merged
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Szegoo @kianenigma
@ordian @ark0f
New Pallet: Root offences (paritytech#11943)
94c6c0f 
* root-offences pallet

* fix errors

* cleaned up a bit

* remove unwrap()

* new pallet is getting compiled

* remove unnecessary type annotations

* remove more unnecessary type annotations

* addidtional cleaning

* commit

* cleaned up

* fix in logic

* add event

* removed Clone trait from AccountId

* test module

* remove unused imports

* fmt

* fix

* separate into functions, still messy

* test

* first test

* fmt

* cleaned up a bit

* separate into mock.rs and tests.rs

* basic docs for now

* pallet_staking GenesisiConfig

* fix

* added start_session

* passing tests

* impl GenesisConfig for pallet_session

* updated event

* Update frame/root-offences/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/root-offences/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* remove <T: Config

* specifying trait bounds inside Config

* commit

* active era increases correctly :)

* ExtBuilder

* slashing works

* new test

* additional test

* commit

* order

* fix?

* fix in logic

* remove unnecessary

* wrap comment at 100

* fmt

* merge fixes

* Update frame/root-offences/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/root-offences/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* docs

* Update frame/root-offences/README.md

Co-authored-by: Andronik <write@reusable.software>

* Update frame/root-offences/Cargo.toml

Co-authored-by: Andronik <write@reusable.software>

* license header

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Andronik <write@reusable.software>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang left review comments

@ordian ordian ordian approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow submitting offences from root
7 participants
@Szegoo @paritytech-cicd-pr @kianenigma @ordian @shawntabrizi @mordamax @KiChjang