Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use array-bytes for All Array/Bytes/Hex Operations #12190

Merged
merged 10 commits into from
Sep 21, 2022
Merged

Use array-bytes for All Array/Bytes/Hex Operations #12190

merged 10 commits into from
Sep 21, 2022

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier commented Sep 5, 2022 •
edited
Loading

Close #12111.

cc @bkchr

@AurevoirXavier
Copy link
Contributor Author

BTW, how do you guys run the tests?

cargo test --all --all-features takes 80G RAM. I have to increase my SWAPMEM. The compile progress is so slow.

@ggwpez
Copy link
Member

ggwpez commented Sep 7, 2022 •
edited
Loading

BTW, how do you guys run the tests?
cargo test --all --all-features takes 80G RAM. I have to increase my SWAPMEM. The compile progress is so slow.

As a FRAME developer I normally use the pallet tests to gauge if the CI will likely pass.
This is often enough since they cover a large part of the code. Together with cargo-nextest:

# Depending in your shell you may have to escape the *
cargo nextest run -p "pallet-*" --all-features

This is no problem on a 32GB machine. If you have too many cores for the ram you can limit parallelism with -j.

@AurevoirXavier
Copy link
Contributor Author

AurevoirXavier commented Sep 8, 2022 •
edited
Loading 

cargo test --release --features runtime-benchmarks

All tests passed. Please review.

acatangiu
acatangiu approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes look good

bkchr
bkchr approved these changes Sep 19, 2022
View reviewed changes
primitives/beefy/src/commitment/test_data.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Sep 20, 2022

@AurevoirXavier please merge master

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 20, 2022
@shawntabrizi
Copy link
Member

bot rebase

@paritytech-processbot
Copy link

Rebased

@athei
Copy link
Member

athei commented Sep 21, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 409167e into paritytech:master Sep 21, 2022
@AurevoirXavier AurevoirXavier deleted the xavier/array-bytes branch September 21, 2022 06:14
ordian added a commit that referenced this pull request Sep 23, 2022
@ordian
Merge branch 'master' into ao-update-kvdb-and-co
45adc12 
* master:
  [Fix] parameter_types! dead code errors (#12340)
  [Feature] Sequential migration execution for try-runtime (#12319)
  bench: Use `_` instead  of `::` in auto-generated file names (#12332)
  Fast Unstake Pallet (#12129)
  Rename anonymous to pure proxy (#12283)
  Migrate remaining old decl_* macros to the new pallet attribute macros (#12271)
  pallet-utility: Disallow none origin (#12321)
  Make automatic storage deposits resistant against changing deposit prices (#12083)
  Format templates and fix `--steps` default value (#12286)
  Bump `wasmtime` to 1.0.0 (#12317)
  Introduce 'intermediate_insert' method to hide implementation details (#12215)
  Bound staking storage items (#12230)
  Use `array-bytes` for All Array/Bytes/Hex Operations (#12190)
  BREAKING: Rename Origin (#12258)
  Use temporary db for benchmarking (#12254)
  rpc: Implement `chainSpec` RPC API (#12261)
  Import target block body during warp sync (#12300)
  Proper naming wrt expectations (#12311)
  [ci] Revert cancel-pipeline job (#12309)
@AurevoirXavier AurevoirXavier mentioned this pull request Sep 27, 2022
Merged
@Niederb Niederb mentioned this pull request Oct 11, 2022
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Nov 23, 2022
Open
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@AurevoirXavier @ark0f
Use array-bytes for All Array/Bytes/Hex Operations (paritytech#12190)
7703f7b 
* Use `array-bytes` for All Array/Bytes/Hex Operations

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* Reorder

* Self Review

* Format

* Fix Tests

* Bump `array-bytes`

* Optimize large test res

Signed-off-by: Xavier Lau <xavier@inv.cafe>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@athei athei athei approved these changes

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using array-bytes for Array/Bytes/Hex Operation
6 participants
@AurevoirXavier @ggwpez @bkchr @shawntabrizi @athei @acatangiu