Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Member request #12

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Member request #12

merged 4 commits into from
Sep 29, 2022

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier commented Sep 27, 2022

Hi, I'm Xavier Lau.
I am a core developer from Darwinia Network, having worked on Substrate and Polkadot ecosystem for the last three years.

I think I should be in the rank range of 2~3.


I'm:

I/my team found:

  • a non-deterministic behavior on Substrate. Due to security issues, @gavofyork suggests I delete the detail. So the issue is empty.
  • some weird code during the Polkadot code review and reported to @kianenigma. PR
  • the MMR leaves can be overwritten by the forks and reported to @tomusdrw. Issue

My PR(s) related to the protocol:

Most of the time, I'm doing the code review.
A little bit of shame, I don't have a lot of PRs contributions.


BTW, I format the markdown and sort the members by their names.

@rphmeier
Copy link
Collaborator

rphmeier commented Sep 27, 2022

Xavier,

Thanks for the request. You're a longstanding member of the community who I recognize as a major contributor to stackexchange and in developer chats. Still, the Fellowship at the moment is constrained to core protocol contributions, and in that respect I do not see enough of a record of contribution to merit III or IV Dan. I would suggest applying for I or II Dan and to re-evaluate after some deeper protocol contributions.

Quoting from III Dan requirements:

As a foundational grade, a Fellow represents both a ceiling and a floor: becoming
a Fellow indicates the individual has enough knowledge and skill to build
substantial protocol components (i.e. all but the major protocol components,
e.g. a pallet or 2-10,000 line crate) alone and with high expectations that they
will be completed correctly and to a high standard

@AurevoirXavier
Copy link
Contributor Author

AurevoirXavier commented Sep 28, 2022

Xavier,

Thanks for the request. You're a longstanding member of the community who I recognize as a major contributor to stackexchange and in developer chats. Still, the Fellowship at the moment is constrained to core protocol contributions, and in that respect I do not see enough of a record of contribution to merit III or IV Dan. I would suggest applying for I or II Dan and to re-evaluate after some deeper protocol contributions.

Quoting from III Dan requirements:

As a foundational grade, a Fellow represents both a ceiling and a floor: becoming
a Fellow indicates the individual has enough knowledge and skill to build
substantial protocol components (i.e. all but the major protocol components,
e.g. a pallet or 2-10,000 line crate) alone and with high expectations that they
will be completed correctly and to a high standard

Updated.

jacogr
jacogr previously requested changes Sep 29, 2022
README.md Outdated Show resolved Hide resolved
@gavofyork gavofyork enabled auto-merge (squash) September 29, 2022 16:15
Copy link
Contributor

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis-read and thought this was an application for I Dan - that I would back happily.

@jacogr
Copy link
Collaborator

jacogr commented Sep 29, 2022

I'm a huge fan of the work I have been seeing, especially around the (mostly) thankless efforts on SE.

Having said that, I'm also on agreement on a I Dan request.

Based on the II Dan requirements, I do feel we are missing the "assisted in implementing a major component" part of the requirement.

auto-merge was automatically disabled September 29, 2022 17:14

Head branch was pushed to by a user without write access

@bkchr bkchr merged commit 02df55b into polkadot-fellows:main Sep 29, 2022
@kianenigma
Copy link
Contributor

Late to the decision, but indeed wanted to appreciate numerous valuable and insightful bug reports that I have received from @AurevoirXavier over the years 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants