Reward pool migration fix #13715

rossbulat · 2023-03-26T16:10:32Z

RewardPools are currently not being decoded on Westend. This may be because of a migration that was needed on RewardPool for new commission counter fields total_commission_pending and total_commission_claimed.

polkadot companion: paritytech/polkadot#6957

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

frame/nomination-pools/src/migration.rs

ruseinov

looks good. Please verify this works via try-runtime before merging.

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>

rossbulat · 2023-03-27T07:21:02Z

bot fmt

command-bot · 2023-03-27T07:21:08Z

@rossbulat https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2592554 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 47-f150f132-87a6-4270-908d-177324bd9b6c to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-03-27T07:22:39Z

@rossbulat Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2592554 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2592554/artifacts/download.

kianenigma · 2023-03-27T07:26:44Z

interestingly, could have been caught by #13013

kianenigma · 2023-03-27T07:29:59Z

frame/nomination-pools/src/migration.rs

+				log!(info, "🔥 There are {} undecodable RewardPools in storage. This migration will try to correct them. keys: {}, values: {}", rpool_keys.saturating_sub(rpool_values), rpool_keys, rpool_values);
+			}
+
+			ensure!(


This is all fine, but end game is have #13013.

Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez

I added two more commits to:

Make the V4 migration re-usable
Add a MigrateV3ToV5 wrapper

rossbulat · 2023-03-27T15:01:51Z

bot merge

* reward pool migration fix * comment * remove generic * rm max * foramtting * Add note to V4 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add more asserts to the V5 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make compile Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/migration.rs Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com> * Make V4 migration re-usable Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add MigrateV3ToV5 wrapper Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>

ggwpez · 2023-04-03T10:23:36Z

For posterity:
This fixes encoding errors for all prefix keys 0x7a6d38deaa01cb6e76ee69889f169627fa0883f96ad25255581bef5ba72b8750...

* reward pool migration fix * comment * remove generic * rm max * foramtting * Add note to V4 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add more asserts to the V5 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make compile Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/migration.rs Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com> * Make V4 migration re-usable Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add MigrateV3ToV5 wrapper Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>

# Goal The goal of this PR is upgrade Polkadot to v0.9.42 Polkadot Release Notes: https://github.com/paritytech/polkadot/releases/tag/v0.9.42 https://github.com/paritytech/polkadot/releases/tag/v0.9.41 https://github.com/paritytech/polkadot/releases/tag/v0.9.40 Polkadot Release Analysis: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1 Closes #1472 Closes #1270 Closes #1332 # Discussion - v0.9.40 was not working and there was evidence that changes in v0.9.42 were related, so we decided to jump ahead to v0.9.42  # Runtime Migrations Included - [x] paritytech/polkadot#6937 - [x] paritytech/substrate#13715 - [x] paritytech/substrate#13936 - [x] paritytech/polkadot#7114 - [x] Further all migrations from 9.38+ are included: paritytech/polkadot#7162) # Checklist - [x] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [ ] Tests added - [ ] Benchmarks added - [x] Weights updated # Tests Performed - [x] `make ci-local` -- Passing (includes lint, docs, unit-test and integration-test) - [x] `make start-native` -- Successfully attached debugger when creating MSA with Polkadot UI - [x] `make start-relay` -- Docker Containers successfully started, but too slow in emulation on Apple Silicon M2. - [x] `make upgrade-local` -- Successfully started local relay network and upgraded to a newer test runtime. - [x] `make upgrade-local` -- Successfully updated a node running the current version on branch `main` --------- Co-authored-by: Frequency CI [bot] <do-not-reply@users.noreply.github.com> Co-authored-by: Matthew Orris <--help> Co-authored-by: Robert La Ferla <robert@onemsg.co>

* reward pool migration fix * comment * remove generic * rm max * foramtting * Add note to V4 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add more asserts to the V5 migration Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make compile Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/migration.rs Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com> * Make V4 migration re-usable Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add MigrateV3ToV5 wrapper Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>

reward pool migration fix

c82c7ad

rossbulat added A0-please_review Pull request needs code review. I3-bug The node fails to follow expected behavior. labels Mar 26, 2023

Ross Bulat added 2 commits March 26, 2023 23:16

comment

fa25d1c

remove generic

c1d1da8

rossbulat mentioned this pull request Mar 26, 2023

Nomination Pools migration v5: RewardPool fix paritytech/polkadot#6957

Merged

Ross Bulat and others added 5 commits March 26, 2023 23:56

rm max

0a35b40

foramtting

172c3a9

Add note to V4 migration

b325b25

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Add more asserts to the V5 migration

ad19222

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Make compile

4093158

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

rossbulat marked this pull request as ready for review March 27, 2023 01:50

rossbulat requested a review from a team March 27, 2023 01:50

rossbulat requested review from ruseinov, Ank4n, ggwpez and gpestana March 27, 2023 01:55

gpestana approved these changes Mar 27, 2023

View reviewed changes

frame/nomination-pools/src/migration.rs Outdated Show resolved Hide resolved

ruseinov approved these changes Mar 27, 2023

View reviewed changes

Update frame/nomination-pools/src/migration.rs

985286c

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>

kianenigma reviewed Mar 27, 2023

View reviewed changes

kianenigma approved these changes Mar 27, 2023

View reviewed changes

kianenigma removed the I3-bug The node fails to follow expected behavior. label Mar 27, 2023

ggwpez added 2 commits March 27, 2023 12:55

Make V4 migration re-usable

298dacd

Otherwise it wont chain together with the V5. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Add MigrateV3ToV5 wrapper

9b60539

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez approved these changes Mar 27, 2023

View reviewed changes

paritytech-processbot bot merged commit 46bdb43 into master Mar 27, 2023

paritytech-processbot bot deleted the rb-reward-pool-migration-fix branch March 27, 2023 15:02

jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Mar 29, 2023

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

mattheworris mentioned this pull request Jun 12, 2023

Upgrade to Polkadot 0.9.42 frequency-chain/frequency#1590

Merged

16 tasks

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Ad96el mentioned this pull request Jun 26, 2023

chore: polkadot 0.9.42 KILTprotocol/kilt-node#527

Merged

6 tasks

ggwpez mentioned this pull request Mar 28, 2023

Detect storage migration requirements in CI paritytech/polkadot-sdk#233

Open

ukint-vs mentioned this pull request Aug 26, 2023

feat: Update substrate to v0.9.42 gear-tech/gear#3186

Closed

2 tasks

ukint-vs mentioned this pull request Oct 24, 2023

feat: Update substrate to v0.9.43 gear-tech/gear#3446

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reward pool migration fix #13715

Reward pool migration fix #13715

rossbulat commented Mar 26, 2023 •

edited

Loading

ruseinov left a comment

rossbulat commented Mar 27, 2023

command-bot bot commented Mar 27, 2023 •

edited

Loading

command-bot bot commented Mar 27, 2023

kianenigma commented Mar 27, 2023

kianenigma Mar 27, 2023

ggwpez left a comment

rossbulat commented Mar 27, 2023

ggwpez commented Apr 3, 2023

Reward pool migration fix #13715

Reward pool migration fix #13715

Conversation

rossbulat commented Mar 26, 2023 • edited Loading

ruseinov left a comment

Choose a reason for hiding this comment

rossbulat commented Mar 27, 2023

command-bot bot commented Mar 27, 2023 • edited Loading

command-bot bot commented Mar 27, 2023

kianenigma commented Mar 27, 2023

kianenigma Mar 27, 2023

Choose a reason for hiding this comment

ggwpez left a comment

Choose a reason for hiding this comment

rossbulat commented Mar 27, 2023

ggwpez commented Apr 3, 2023

rossbulat commented Mar 26, 2023 •

edited

Loading

command-bot bot commented Mar 27, 2023 •

edited

Loading