This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Disarm OnRuntimeUpgrade::pre/post_upgrade Tuple footgun
#14759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A0-please_review
ggwpez
reviewed
Aug 14, 2023
KiChjang
reviewed
Aug 15, 2023
KiChjang
reviewed
Aug 15, 2023
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
muharem
reviewed
Aug 15, 2023
liamaharon
changed the title
OnRuntimeUpgrade::pre/post_upgrade is called on a tuple of pallets OnRuntimeUpgrade::pre/post_upgrade for tuples
liamaharon
changed the title
OnRuntimeUpgrade::pre/post_upgrade for tuplesOnRuntimeUpgrade::pre/post_upgrade tuple footgun
liamaharon
changed the title
OnRuntimeUpgrade::pre/post_upgrade tuple footgunOnRuntimeUpgrade::pre/post_upgrade Tuple footgun
KiChjang
reviewed
Aug 16, 2023
KiChjang
reviewed
Aug 16, 2023
KiChjang
reviewed
Aug 16, 2023
|
CI is complaining about the |
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
muharem
approved these changes
Aug 16, 2023
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
sam0x17
approved these changes
Aug 16, 2023
…turn-error-on-incorrect-pre_upgrade-post_upgrade-tuple-usage
liamaharon
requested review from
a team
and removed request for
kianenigma,
ggwpez and
KiChjang
liamaharon
changed the title
OnRuntimeUpgrade::pre/post_upgrade Tuple footgunOnRuntimeUpgrade::pre/post_upgrade Tuple footgun
|
bot merge |
paritytech-processbot
bot
deleted the
liam-return-error-on-incorrect-pre_upgrade-post_upgrade-tuple-usage
branch
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
* return error on incorrect tuple usage of pre_upgrade and post_upgrade * add test * comment lint * Update frame/support/src/traits/hooks.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * address feedback * Update frame/support/src/traits/hooks.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * muharem comments * Update frame/support/src/traits/hooks.rs Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com> * remove useless type --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of the
Executivepallet callspre_upgradeandpost_upgradeon a tuple of pallets which was made a silent noop in #12537.This can lead to confusion, see #13681.
This PR changes the noop behavior into a noisy error to inform devs of the incorrect usage and improves documentation so it's clear how to fix it.
also has insubstantial fix I forgot to push before I merged this PR: #14779 (comment)