Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Disarm OnRuntimeUpgrade::pre/post_upgrade Tuple footgun #14759

Merged
merged 14 commits into from
Aug 16, 2023
Merged

Disarm OnRuntimeUpgrade::pre/post_upgrade Tuple footgun #14759

merged 14 commits into from
Aug 16, 2023

Commits on Aug 14, 2023

  1. return error on incorrect tuple usage of pre_upgrade and post_upgrade

    @liamaharon
    liamaharon committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a66a86a View commit details
    Browse the repository at this point in the history

  2. add test

    @liamaharon
    liamaharon committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    e3b18d5 View commit details
    Browse the repository at this point in the history

  3. comment lint

    @liamaharon
    liamaharon committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3ab6c97 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @liamaharon @KiChjang
    liamaharon and KiChjang authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fce0505 View commit details
    Browse the repository at this point in the history

  2. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @liamaharon @KiChjang
    liamaharon and KiChjang authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    492fc41 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. address feedback

    @liamaharon
    liamaharon committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b5f7735 View commit details
    Browse the repository at this point in the history

  2. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @liamaharon @KiChjang
    liamaharon and KiChjang authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    63bc648 View commit details
    Browse the repository at this point in the history

  3. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @liamaharon @KiChjang
    liamaharon and KiChjang authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    fbc93eb View commit details
    Browse the repository at this point in the history

  4. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @liamaharon @KiChjang
    liamaharon and KiChjang authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5b04c4d View commit details
    Browse the repository at this point in the history

  5. muharem comments

    @liamaharon
    liamaharon committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b73aa78 View commit details
    Browse the repository at this point in the history

  6. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
    @liamaharon @muharem
    liamaharon and muharem authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7b1e3dd View commit details
    Browse the repository at this point in the history

  7. Update frame/support/src/traits/hooks.rs 

    Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
    @liamaharon @muharem
    liamaharon and muharem authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    08b93b5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:paritytech/substrate into liam-re… 

    …turn-error-on-incorrect-pre_upgrade-post_upgrade-tuple-usage
    @liamaharon
    liamaharon committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5d262ff View commit details
    Browse the repository at this point in the history

  9. remove useless type

    @liamaharon
    liamaharon committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    17684ac View commit details
    Browse the repository at this point in the history