This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
BABE Epochs #3028
Merged
BABE Epochs #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Jul 5, 2019
rphmeier
reviewed
Jul 5, 2019
rphmeier
reviewed
Jul 5, 2019
Closed
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Currently causes a stack overflow in the compiler
andresilva
force-pushed
the
demi-sign-epoch-randomness
branch
from
a2230d8
to
39ec92e
Compare
andresilva
reviewed
Jul 22, 2019
andresilva
force-pushed
the
demi-sign-epoch-randomness
branch
from
27a2e37
to
2017cd4
Compare
andresilva
force-pushed
the
demi-sign-epoch-randomness
branch
from
5e2b85a
to
0cb53cc
Compare
andresilva
approved these changes
Jul 22, 2019
rphmeier
reviewed
Jul 22, 2019
| fn import_block( | ||
| &mut self, | ||
| mut block: BlockImportParams<Block>, | ||
| new_cache: HashMap<well_known_cache_keys::Id, Vec<u8>>, |
There was a problem hiding this comment.
what is this populated with when the blocks don't come from the authorship task?
There was a problem hiding this comment.
https://github.com/paritytech/substrate/pull/3028/files#diff-671e8a8d7d8649656f0988fafca31301R689 same thing. the import queue then just create an hashmap and adds those keys in.
rphmeier
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for epochs to BABE. Most of the plumbing is done, but the code is still a WIP.
This is a draft, but I would appreciate review on what I have done so far, so as to know that I am on the right track.
Closes #2435
Closes #2436