This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Change to use the same subcommand syntax as subkey #8678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
added
A0-please_review
bkchr
reviewed
Apr 27, 2021
tomusdrw
reviewed
Apr 27, 2021
|
@bkchr I compiled and this is working with the |
bkchr
approved these changes
May 4, 2021
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
May 4, 2021
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
May 4, 2021
* Bump Substrate to commit `b094edafd1cd5d26e49ecbf92b0ce7553cfad717` * Remove unsafe random seed method See: paritytech/substrate#8718 * Update Subkey syntax See: paritytech/substrate#8678
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Change to use the same subcommand syntax as subkey * Update client/cli/src/commands/inspect_key.rs * revert to InspectKeyCmd struct
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency between the two tools, the subcommand for
<node bin> key inspect-keyis changed to matchsubkeysyntax (subkey inspect)This may need modification of downstream dependencies in Polkadot and other code bases. I do not see this is the case, bu would be good to have a double-check on that and a companion PR made if so.
Alternatively to this PR, changing the subkey
inspectcommand toinspect-keywould have the same (but more verbose) effect.Compliments/Related to #8674