Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert Changes: InspectKeyCmd back to InspectCmd where appropriate #8787

Merged
merged 1 commit into from
May 12, 2021
Merged

Revert Changes: InspectKeyCmd back to InspectCmd where appropriate #8787

merged 1 commit into from
May 12, 2021

Conversation

nuke-web3
Copy link
Contributor

#8678 introduced an error renaming a struct to InspectKeyCmd incorrectly, this brings it back to InspectCmd

The struct is internal only, so no version bump or release notes are needed (I think?)

This introduced an issue upstream that this PR will correct.

So we'll need a Substrate PR to revert the changes, and then a PR which bumps Substrate in this repo (and in that PR changes the name back)

@nuke-web3 nuke-web3 added A0-please_review Pull request needs code review. Z0-trivial Writing the issue is of the same difficulty as patching the code. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 12, 2021
@nuke-web3 nuke-web3 mentioned this pull request May 12, 2021
Merged
adoerr
adoerr approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoerr adoerr merged commit 4ff92f1 into master May 12, 2021
@adoerr adoerr deleted the node_inspect_fix branch May 12, 2021 05:47
@tomusdrw tomusdrw added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels May 12, 2021
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
@nuke-web3 @nazar-pc
revert changes: InspectKeyCmd back to InspectCmd where appropriate (p…
fd8f404 
…aritytech#8787)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adoerr adoerr adoerr approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. Z0-trivial Writing the issue is of the same difficulty as patching the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuke-web3 @shawntabrizi @adoerr @tomusdrw