This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimate call fee #9395
Estimate call fee #9395
Changes from 6 commits
3a9606c
291436f
7cbe189
03bf0a7
40eb200
4b81d6a
6c29266
63c7e81
efaf1ec
2f6bdf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called
MaxCallFee
?Estimate implies to me it could be more or less, and that it is actually estimating something, but really it can only be less than this fee. This is just the max.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to take into account that other implementations might differ, and might be more or less. The implementation by
transaction-payment
is actually accurate to the point (excluding tip).But the trait name should not be moulded by the implementation detail, IMO in any case.