This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Estimate call fee #9395
Merged
Estimate call fee #9395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tech/substrate into kiz-call-estimator
kianenigma
added
A0-please_review
emostov
reviewed
Jul 22, 2021
emostov
reviewed
Jul 22, 2021
emostov
approved these changes
Jul 22, 2021
|
/benchmark runtime pallet pallet-staking |
|
Benchmark Runtime Pallet for branch "kiz-call-estimator" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame//src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-call-estimator
| @@ -656,6 +656,19 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Config, AnyCall: GetDispatchInfo + Encode> EstimateCallFee<AnyCall, BalanceOf<T>> | |||
There was a problem hiding this comment.
Should this be called MaxCallFee?
Estimate implies to me it could be more or less, and that it is actually estimating something, but really it can only be less than this fee. This is just the max.
There was a problem hiding this comment.
I'm trying to take into account that other implementations might differ, and might be more or less. The implementation by transaction-payment is actually accurate to the point (excluding tip).
But the trait name should not be moulded by the implementation detail, IMO in any case.
shawntabrizi
approved these changes
Jul 23, 2021
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
|
/benchmark runtime pallet pallet-staking |
|
Benchmark Runtime Pallet for branch "kiz-call-estimator" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame//src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
jakoblell
added
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9247
This will allow us to properly know roughly how much fee will be consumed for a given call within a dispatch, and store it. We then use this later to give an appropriate reward to the signed submissions.
TODO:
CallFeeEstimatorineleciton-providerthat just assumesscore[0](or some fixed amount) is the correct amountsubstrate/pull/9395) polkadot#3465 the companion of this PR, update rewards to a small value, like1 * DOLLARpolkadot companion: paritytech/polkadot#3465