Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Reduce staking miner reward (companion substrate/pull/9395) #3465

Merged
10 commits merged into from
Jul 23, 2021

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Jul 13, 2021

EDIT

We now use the call fee plus a fixed reward base to determine the staking miner reward.

substrate companion: paritytech/substrate#9395


Below is the outdated approach

The plan is to reduce the staking miner reward until all the components of the signed phase solution submission apparatus have been battle tested

Currently, the polkadot reward is around 24 DOTs per era. Given that the signed solution submission process is still in the early stages of rollout we rather keep the reward low while things are honed in, and then look into raising it from there. Long term we expect teams to spend near-full-time effort on building staking miners, and thus a decent reward.

How can this be the right solution?

This PR uses the approach of hardcoding a decrease for SignedRewardBase. In order to lower the reward, we decrease the expected signed solution length in all the calculations. The lengths used here are based on current solution lengths for each chain.

Another approach would involve keeping track of the exact fee paid for the submission (paritytech/substrate#9247) and then using that to create the SignedRewardBase.

And how was this decrease amount selected?

The decrease here stems from decreasing the expected length of the submission. The justification lies in the fact that the new lengths closely follow what we currently see on chain.

cc: @kianenigma
rel: #3393

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jul 13, 2021
@emostov emostov added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. C3-medium PR touches the given topic and has a medium impact on builders. and removed C3-medium PR touches the given topic and has a medium impact on builders. labels Jul 13, 2021
@shawntabrizi
Copy link
Member

shawntabrizi commented Jul 15, 2021

I am very confused. You want to fix the fee here, but you are decreasing some assumption about how long the solution message is?

How can this be the right solution?

And how was this decrease amount selected?

This makes very little sense out of context.

@kianenigma
Copy link
Contributor

@shawntabrizi paritytech/substrate#9395 is the right solution for this.

@kianenigma kianenigma changed the title Reduce staking miner reward Reduce staking miner reward (companion substrate/pull/9395) Jul 22, 2021
@kianenigma kianenigma marked this pull request as ready for review July 22, 2021 09:12
@kianenigma kianenigma added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. B1-releasenotes labels Jul 22, 2021
@emostov
Copy link
Contributor Author

emostov commented Jul 22, 2021

@kianenigma ✅ (just can't officially do it since I opened the PR)

@shawntabrizi
Copy link
Member

seems to be missing the estimatefee config

@ghost
Copy link

ghost commented Jul 23, 2021

Waiting for commit status.

@ghost ghost merged commit 5dac532 into master Jul 23, 2021
@ghost ghost deleted the zeke-adjust-staking-miner-reward branch July 23, 2021 09:58
ordian added a commit that referenced this pull request Jul 23, 2021
* master:
  Reduce staking miner reward (companion `substrate/pull/9395`) (#3465)
  Parachains shared.rs to Frame V2 (#3425)
  Parachains hrmp.rs to Frame V2 (#3475)
  Migrate slots pallet to pallet attribute macro. (#3218)
  Improve test in bridge (#3507)
  parachain dmp.rs to Frame V2 (#3426)
  Parachains inclusion.rs to Frame V2 (#3440)
  Dispute coordinator - Recover disputes on startup (#3481)
  Use correct syntax for owning all files in a folder (#3510)
  Add wococo-local chain spec (#3509)
  Dispute vote filtering for block authors (#3498)
  Bump indexmap from 1.6.1 to 1.7.0 (#3497)
  Companion for substrate #9315 (#3477)
@jakoblell jakoblell added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 16, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants