This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Parachains hrmp.rs to Frame V2 #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on reviewing these. |
KiChjang
added
A0-please_review
|
No worries, I'm chillin |
shawntabrizi
approved these changes
Jul 22, 2021
shawntabrizi
added
B7-runtimenoteworthy
E0-runtime_migration
gui1117
approved these changes
Jul 22, 2021
| } | ||
| #[pallet::event] | ||
| #[pallet::generate_deposit(pub(super) fn deposit_event)] | ||
| pub enum Event<T: Config> { |
There was a problem hiding this comment.
I think event doesn't needs to be generic, however I'm ok with it anyway.
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Jul 23, 2021
* master: Reduce staking miner reward (companion `substrate/pull/9395`) (#3465) Parachains shared.rs to Frame V2 (#3425) Parachains hrmp.rs to Frame V2 (#3475) Migrate slots pallet to pallet attribute macro. (#3218) Improve test in bridge (#3507) parachain dmp.rs to Frame V2 (#3426) Parachains inclusion.rs to Frame V2 (#3440) Dispute coordinator - Recover disputes on startup (#3481) Use correct syntax for owning all files in a folder (#3510) Add wococo-local chain spec (#3509) Dispute vote filtering for block authors (#3498) Bump indexmap from 1.6.1 to 1.7.0 (#3497) Companion for substrate #9315 (#3477)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #2882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Hrmppallet must be careful about the name they used inconstruct_runtime!.Hence the runtime-migration label, which might not be needed depending on the configuration of theHrmppallet.rococo uses
Hrmpinconstruct_runtime!, so no mirgration neededkusama and westend use
ParasHrmpinconstruct_runtime!so I migrated them toHrmppolkadot does not us
Hrmp.