This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Parachains shared.rs to Frame V2 #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrell-code
commented
Jul 7, 2021
Comment on lines
532
to
538
| ParasInherent: parachains_paras_inherent::{Pallet, Call, Storage, Inherent}, | ||
| Initializer: parachains_initializer::{Pallet, Call, Storage}, | ||
| Paras: parachains_paras::{Pallet, Call, Storage, Origin, Event}, | ||
| ParasShared: parachains_shared::{Pallet, Call, Storage}, | ||
| Scheduler: parachains_scheduler::{Pallet, Call, Storage}, | ||
| ParasSudoWrapper: paras_sudo_wrapper::{Pallet, Call}, | ||
| SessionInfo: parachains_session_info::{Pallet, Call, Storage}, |
There was a problem hiding this comment.
pallet must be put in construct_runtime for tests... if you make a call into ParasShared storage without doing so frame_support will panic as it needs a pallet name (the one that was previously declared in decl_storage!).
I probably should check if any of cumulus tests do this (don't think CI checks)
Edit: I believe it is all good, but if any tests randomly start to panic that's why
|
looking at the number of line removed, I guess some master merge got wrong, isn't it ? @ferrell-code |
ferrell-code
force-pushed
the
fer-shared-framev2
branch
from
8ce23f1
to
2a9840d
Compare
|
Tabrizi swooping in with that 5 am merge lol, I force pushed back to the original point, re-merged and resolved conflicts (I know you guys don't like force pushes but I think reverting a merge to re-merge is reasonable) |
KiChjang
approved these changes
Jul 22, 2021
emostov
approved these changes
Jul 22, 2021
KiChjang
added
A0-please_review
|
bot merge |
|
Waiting for commit status. |
emostov
added
E5-breaksapi
C1-low
emostov
added
B0-silent
ghost
merged commit 
|
@ferrell-code yeah sorry about that. Was gonna fix it for you, but then got too tired, and gave up lol |
|
I got a kick out of it, always appreciate your help 🐪 |
ordian
added a commit
that referenced
this pull request
Jul 23, 2021
* master: Reduce staking miner reward (companion `substrate/pull/9395`) (#3465) Parachains shared.rs to Frame V2 (#3425) Parachains hrmp.rs to Frame V2 (#3475) Migrate slots pallet to pallet attribute macro. (#3218) Improve test in bridge (#3507) parachain dmp.rs to Frame V2 (#3426) Parachains inclusion.rs to Frame V2 (#3440) Dispute coordinator - Recover disputes on startup (#3481) Use correct syntax for owning all files in a folder (#3510) Add wococo-local chain spec (#3509) Dispute vote filtering for block authors (#3498) Bump indexmap from 1.6.1 to 1.7.0 (#3497) Companion for substrate #9315 (#3477)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #2882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
ParasSharedpallet must be careful about the name they used inconstruct_runtime!.Hence the runtime-migration label, which might not be needed depending on the configuration of theParasSharedpallet.Kusama and westend both already use
ParasSharedinconstruct_runtime!no migration needed. Polkadot does not use theParasSharedpallet.Rococo uses
Sharedinconstruct_runtime!, therefore I altered it toParasSharedto keep the pallet name the same as seen indecl_storage!ofParasShared