-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exception on concurrent download of ParseFile
from multiple threads
#1180
Conversation
…f the same ParseFile from multiple threads
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 122 122
Lines 9962 9971 +9
Branches 1343 1345 +2
======================================
- Misses 9962 9971 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mtrezza @L3K0V How to solve 'codecov/project' failing issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mtrezza can you help about failing checks |
ParseFile
from multiple threads
ParseFile
from multiple threadsParseFile
from multiple threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This change has been released in version 4.1.0 |
New Pull Request Checklist
Issue Description
Related issue: #1155
Approach
This PR simplifies the logic of fetchAsync method and then adds a concurrent code that blocks the second (and further) calling threads until the first thread finishes the download of ParseFile (or fails to do so).
TODOs before merging