-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade various dependencies #1181
Conversation
Kotlin, facebook login, firebase messaging, android.gms:play-services-auth, fragments, activity-ktx, annotation, okhttp, appcompact updated.
Thanks for opening this pull request!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the FB range, and the PR title, see the failing commit message check, otherwise looks good.
If you want to also upgrade the FB SDK, then I'd do that in a separate PR. As we've seen in the past, since it's a transitive dependency it may require some more deliberation. It's also considered a breaking change, so it would bump the Parse SDK to 5.x and we should probably bump all other dependencies as courtesy first with this PR. |
Codecov Report
@@ Coverage Diff @@
## master #1181 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 122 122
Lines 9971 9971
Branches 1345 1345
======================================
Misses 9971 9971 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I fixed the commit message (PR title) and reverted the FB lib range.
Is this ready for merge?
🎉 This change has been released in version 4.1.0 |
Is this a big deal? I feel like this is a big deal for me. I am grateful to
be part of such a big community.
…On Fri, Aug 26, 2022 at 4:15 PM Parse Platform ***@***.***> wrote:
🎉 This change has been released in version 4.1.0
<https://github.com/parse-community/Parse-SDK-Android/releases/tag/4.1.0>
—
Reply to this email directly, view it on GitHub
<#1181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD62HNZLEMRTSHFHCK25F63V3CMDDANCNFSM57TBSCAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
New Pull Request Checklist
Issue Description
Newer versions were available.
Related issue: #n/a
Approach
I just updated the dependencies.
Kotlin,
facebook login,
firebase messaging,
android.gms:play-services-auth,
fragments,
activity-ktx,
annotation,
okhttp,
appcompact
Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)
A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)