⚡️ Release 2.19.0 #1273
⚡️ Release 2.19.0 #1273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 57 57
Lines 5409 5409
Branches 1204 1204
===========================================
+ Hits 5408 5409 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
| [Full Changelog](https://github.com/parse-community/Parse-SDK-JS/compare/2.18.0...2.19.0) | ||
|
|
||
| **Features** | ||
| - New error code 210 (MFA_ERROR) ([#1268](https://github.com/parse-community/Parse-SDK-JS/pull/1268)) |
There was a problem hiding this comment.
Not sure if these new error codes are required anymore, since parse-community/parse-server#6977 has been closed in favor of a general interface approach in parse-community/parse-server#7052. @dblythy, @Moumouls what do you think?
There was a problem hiding this comment.
You can remoce this error code yes, i think it's not needed any more due to the futur system
There was a problem hiding this comment.
The MFA adapter will still need to throw a "special" error if a login is attempted without a TOTP token. Maybe this should be changed to a more generic error such as "210 (AUTH_ERROR)"
There was a problem hiding this comment.
Okay, I guess it's unclear at this point what the new error codes should be. Let's just keep in mind to make a decision on these codes so that they don't remain there unnecessarily. @Moumouls I added that to a task of your auth adapter PR, just to be sure.
There was a problem hiding this comment.
Yes, I hope I will be able to finish my PR today to remove the draft label and then start the review process with the team :)
Let me know if I missed anything.
I added a release workflow for Github Action.