Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Release 2.19.0 #1273

Merged
merged 3 commits into from
Dec 10, 2020
Merged

⚡️ Release 2.19.0 #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5b647f
⚡️ Release 2.19.0
dplewis Dec 10, 2020
cb31411
Improve coverage and changelog
dplewis Dec 10, 2020
ffca683
cleanup workflow
dplewis Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: docs
on:
push:
branches:
- master
tags:
- '*'
release:
types: [published]
jobs:
build:
runs-on: ubuntu-18.04
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: release
on:
release:
types: [published]
jobs:
publish-npm:
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: https://registry.npmjs.org/
- name: Cache Node.js modules
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
18 changes: 17 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@
# Parse-SDK-JS

### master
[Full Changelog](https://github.com/parse-community/Parse-SDK-JS/compare/2.18.0...master)
[Full Changelog](https://github.com/parse-community/Parse-SDK-JS/compare/2.19.0...master)

## 2.19.0
[Full Changelog](https://github.com/parse-community/Parse-SDK-JS/compare/2.18.0...2.19.0)

**Features**
- New error code 210 (MFA_ERROR) ([#1268](https://github.com/parse-community/Parse-SDK-JS/pull/1268))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these new error codes are required anymore, since parse-community/parse-server#6977 has been closed in favor of a general interface approach in parse-community/parse-server#7052. @dblythy, @Moumouls what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remoce this error code yes, i think it's not needed any more due to the futur system

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MFA adapter will still need to throw a "special" error if a login is attempted without a TOTP token. Maybe this should be changed to a more generic error such as "210 (AUTH_ERROR)"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I guess it's unclear at this point what the new error codes should be. Let's just keep in mind to make a decision on these codes so that they don't remain there unnecessarily. @Moumouls I added that to a task of your auth adapter PR, just to be sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hope I will be able to finish my PR today to remove the draft label and then start the review process with the team :)

- New error code 211 (MFA_TOKEN_REQUIRED) ([#1268](https://github.com/parse-community/Parse-SDK-JS/pull/1268))
- New error code 161 (FILE_DELETE_UNNAMED_ERROR) ([#1257](https://github.com/parse-community/Parse-SDK-JS/pull/1257))

**Improvements**
- Parse.File.destroy without name error message ([#1257](https://github.com/parse-community/Parse-SDK-JS/pull/1257))

**Fixes**
- Remove unnecessary object reference and comment from AddUniqueOp ([#1253](https://github.com/parse-community/Parse-SDK-JS/pull/1253))
- Internal Referencing for Increment Dot Notation ([#1255](https://github.com/parse-community/Parse-SDK-JS/pull/1255))
- Saving for Increment Dot Notation ([#1219](https://github.com/parse-community/Parse-SDK-JS/pull/1219))

## 2.18.0
[Full Changelog](https://github.com/parse-community/Parse-SDK-JS/compare/2.17.0...2.18.0)
Expand Down
26 changes: 13 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "parse",
"version": "2.18.0",
"version": "2.19.0",
"description": "The Parse JavaScript SDK",
"homepage": "https://parseplatform.org/",
"keywords": [
Expand Down
3 changes: 3 additions & 0 deletions src/__tests__/ParseQuery-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,6 +2801,9 @@ describe('ParseQuery', () => {
aggregate: () => {},
});
const query = new ParseQuery('TestCancel');
expect(query._xhrRequest).toBeDefined();
expect(query._xhrRequest.task).toBe(null);
expect(query._xhrRequest.onchange()).toBeUndefined();

jest.spyOn(mockRequestTask, 'abort');
query.cancel();
Expand Down