Merge upstream #12
Open
Merge upstream #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds mutableContent doku entry
Failed tokens can be found with a single `filter` operation over the `registrationTokens` using the 1:1 mapping with response data. Earlier example used `map` + `filter` to achieve the same result.
Update example to find "bad" tokens
…s-message Add fcm_options as allowed params to message object
Normally there is no need to override send URI except for testing
Allow uri override
fix: Gcm InternalServerError should also be retied with exponential-back-off.
dependency upgrades for vulnerabilities flagged by snyk
|
Hi @ToothlessGear, your node-gcm repository is an important module for our Parse Server. We have opened several PRs in the past to fix issues and vulnerabilities. Would you be willing to give our organization maintainer / write access to node-gcm, so we don't have to depend on our fork anymore, because we know we can fix vulnerabilities more timely? I have also opened some issues there so we can make sure vulnerabilities are fixed faster and releases are more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge upstream 1.0.4
The parse-server-push-adapter points to
@parse/node-gcm": "1.0.2", so I assume even when merging this PR, it won’t have any effect. We may have to add our own tag and point to that?