-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validateEmailConfiguration
should be called when sending reset password email
#1649
Comments
Yep that definitely should be called. Not sure when it stopped being called. |
Actually this seems to be a different issue. I made a regression test in #1650 and it passes. |
The regression test you wrote doesn't really test what I mentioned here. I'll comment on the PR. |
@natanrolnik Did you solve it ? I'm facing the exact same problem. I tried with |
@natanrolnik @drew-gross Ok that was a stupid mistake. I forgot the |
* upstream/master: (63 commits) Fixes parse-community#1649 (parse-community#1650) Update issue template (parse-community#1899) Break schemaController dependency. (parse-community#1901) Remove unnecessary null check Update schema mismatch error to include type string (parse-community#1898) Move more mongo specific stuff into mongo adapter Kill mongoOptions Consistent parameter order move transformWhere into mongo adapter Remove options from count Can't sort a count Remove limit from count Destructure mongo options remove adaptive collection call create + use adapter count instead of collection count transformWhere in MongoAdapter remove schemaController paramater Remove schemaController parameter Remove getRelationFields Remove all dependencies on schemaController ...
Environment Setup
Parse Server 2.2.7 on Heroku
Steps to reproduce
requestPasswordReset
Result
Users will receive an email with title "Password reset for undefined", and body:
"You requested to reset your password for undefined. Click here to reset it: undefined/apps/....."
Expected Result
validateEmailConfiguration
or some variation of it should be called before sending reset password emails, to make sure that both app name and public server url were set correctly.The text was updated successfully, but these errors were encountered: