Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateEmailConfiguration should be called when sending reset password email #1649

Closed
3 tasks done
natanrolnik opened this issue Apr 26, 2016 · 5 comments
Closed
3 tasks done

Comments

@natanrolnik
Copy link
Contributor

natanrolnik commented Apr 26, 2016

Environment Setup

Parse Server 2.2.7 on Heroku

Steps to reproduce

  • Configure an Email Adapter in index.js
  • Don't configure app name and/or public server URL
  • Request a reset password email via requestPasswordReset

Result

Users will receive an email with title "Password reset for undefined", and body:

"You requested to reset your password for undefined. Click here to reset it: undefined/apps/....."

Expected Result

validateEmailConfiguration or some variation of it should be called before sending reset password emails, to make sure that both app name and public server url were set correctly.

@drew-gross
Copy link
Contributor

Yep that definitely should be called. Not sure when it stopped being called.

@drew-gross drew-gross added type:bug Impaired feature or lacking behavior that is likely assumed and removed type:bug Impaired feature or lacking behavior that is likely assumed labels Apr 26, 2016
drew-gross added a commit to drew-gross/parse-server that referenced this issue Apr 26, 2016
@drew-gross
Copy link
Contributor

Actually this seems to be a different issue. I made a regression test in #1650 and it passes.

@natanrolnik
Copy link
Contributor Author

natanrolnik commented Apr 27, 2016

The regression test you wrote doesn't really test what I mentioned here. I'll comment on the PR.
I think it's still a bug.

@damtsnkff
Copy link

@natanrolnik Did you solve it ? I'm facing the exact same problem. I tried with parse-server: ~2.2.7 and ~2.2.2

@damtsnkff
Copy link

damtsnkff commented Apr 30, 2016

@natanrolnik @drew-gross Ok that was a stupid mistake. I forgot the publicServerURL... and I was checking the wrong index.js when debugging. Fixed for me.

drew-gross added a commit to drew-gross/parse-server that referenced this issue May 10, 2016
drew-gross added a commit to drew-gross/parse-server that referenced this issue May 10, 2016
drew-gross added a commit to drew-gross/parse-server that referenced this issue May 18, 2016
maninga added a commit to maninga/parse-server that referenced this issue May 26, 2016
* upstream/master: (63 commits)
  Fixes parse-community#1649 (parse-community#1650)
  Update issue template (parse-community#1899)
  Break schemaController dependency. (parse-community#1901)
  Remove unnecessary null check
  Update schema mismatch error to include type string (parse-community#1898)
  Move more mongo specific stuff into mongo adapter
  Kill mongoOptions
  Consistent parameter order
  move transformWhere into mongo adapter
  Remove options from count
  Can't sort a count
  Remove limit from count
  Destructure mongo options
  remove adaptive collection call
  create + use adapter count instead of collection count
  transformWhere in MongoAdapter
  remove schemaController paramater
  Remove schemaController parameter
  Remove getRelationFields
  Remove all dependencies on schemaController
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants