Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1649 #1650

Merged
merged 5 commits into from
May 25, 2016
Merged

Fixes #1649 #1650

merged 5 commits into from
May 25, 2016

Conversation

drew-gross
Copy link
Contributor

No description provided.

@drew-gross drew-gross mentioned this pull request Apr 26, 2016
Closed
3 tasks
@natanrolnik
Copy link
Contributor

natanrolnik commented Apr 27, 2016 •
edited
Loading

Thanks for the PR of this test, @drew-gross. I think I wasn't clear in my description in #1649
I was describing a case when you do have an Email Adapter, but verifyUserEmails is not set, or set to false. In this case, validateEmailConfiguration is not called, but sending an e-mail that uses publicServerURL and appName may still happen if the server receives a call to /requestPasswordReset.
Actually, #1649 has little to do with email validation itself, and relates more to the reset password email.
This way, the test would be defined as something like this:

it('fails if sendPasswordResetEmail is called, without setting an app ID or publicServerURL, and verifyUserEmails is not set or set to false (regression test for #1649)', done => {

@drew-gross
Copy link
Contributor Author

Got it, will fix, thanks.

@drew-gross drew-gross force-pushed the regression-test-1649 branch 2 times, most recently from ca79c48 to 7d08d00 Compare May 10, 2016 00:37
@ghost
Copy link

ghost commented May 10, 2016

@drew-gross updated the pull request.

@drew-gross drew-gross changed the title Regression test #1649 Fixes #1649 May 10, 2016
@drew-gross drew-gross force-pushed the regression-test-1649 branch from 7d08d00 to 8b910db Compare May 18, 2016 00:54
@ghost
Copy link

ghost commented May 18, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented May 18, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented May 18, 2016

@drew-gross updated the pull request.

@natanrolnik
Copy link
Contributor

Looks good, that's exactly what I meant.

@drew-gross
Copy link
Contributor Author

Unfortunately the tests are failing, and I can't figure out why, so I can't merge this yet :(

@flovilmart
Copy link
Contributor

All tests a good!

@flovilmart
Copy link
Contributor

LGTM!

@flovilmart flovilmart merged commit 0850c18 into parse-community:master May 25, 2016
@drew-gross drew-gross deleted the regression-test-1649 branch May 26, 2016 01:25
maninga added a commit to maninga/parse-server that referenced this pull request May 26, 2016
@maninga
Merge remote-tracking branch 'upstream/master'
0cb352e 
* upstream/master: (63 commits)
  Fixes parse-community#1649 (parse-community#1650)
  Update issue template (parse-community#1899)
  Break schemaController dependency. (parse-community#1901)
  Remove unnecessary null check
  Update schema mismatch error to include type string (parse-community#1898)
  Move more mongo specific stuff into mongo adapter
  Kill mongoOptions
  Consistent parameter order
  move transformWhere into mongo adapter
  Remove options from count
  Can't sort a count
  Remove limit from count
  Destructure mongo options
  remove adaptive collection call
  create + use adapter count instead of collection count
  transformWhere in MongoAdapter
  remove schemaController paramater
  Remove schemaController parameter
  Remove getRelationFields
  Remove all dependencies on schemaController
  ...
@snyk-bot snyk-bot mentioned this pull request Sep 9, 2020
Open
This was referenced Apr 7, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drew-gross @natanrolnik @flovilmart