Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot update installations with useMasterKey #2887

Closed
JeremyPlease opened this issue Oct 19, 2016 · 0 comments
Closed

Cannot update installations with useMasterKey #2887

JeremyPlease opened this issue Oct 19, 2016 · 0 comments

Comments

@JeremyPlease
Copy link
Contributor

PR #2739 that fixes issue #2090 caused a regression that prevents installation objects from being updated.

Example:

let installationObj = Parse.Installation.createWithoutData(objectId);
installationObj.set('customField', 'custom value');
installationObj.save(null, {useMasterKey: true});

This returns ParseError { code: 136, message: 'installationId may not be changed in this operation' }

I'll push the failing test case as a WIP PR and try to fix in RestWrite.js. @flovilmart Any quick suggestions or pointers?
@JeremyPlease JeremyPlease mentioned this issue Oct 19, 2016
Merged
@flovilmart flovilmart reopened this Oct 19, 2016
JeremyPlease added a commit to JeremyPlease/parse-server that referenced this issue Oct 19, 2016
@JeremyPlease
Prevent auth.installationId from being used when using masterKey
2484b83 
This allows masterKey to update any installation object
Fixes ParsePlatform/parse-server#parse-community#2887
flovilmart pushed a commit that referenced this issue Oct 19, 2016
@JeremyPlease @flovilmart
Fix error when updating installation with useMasterKey (#2888)
a6a6f7f 
* Add failing test for updating installations with masterKey

* Prevent auth.installationId from being used when using masterKey

This allows masterKey to update any installation object
Fixes ParsePlatform/parse-server##2887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeremyPlease @flovilmart