Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when updating installation with useMasterKey #2888

Conversation

JeremyPlease
Copy link
Contributor

@JeremyPlease JeremyPlease commented Oct 19, 2016

When using useMasterKey the auth.installationId should not be used from the request. Otherwise, errors will be thrown when installation object being edited is not the same as auth.installationId.

Fixes #2887.

This allows masterKey to update any installation object
Fixes ParsePlatform/parse-server#parse-community#2887
@facebook-github-bot
Copy link

@JeremyPlease updated the pull request - view changes

@JeremyPlease JeremyPlease changed the title WIP: Test case to reproduce #2887 Fix error when updating installation with useMasterKey Oct 19, 2016
@flovilmart
Copy link
Contributor

Awesome!!!

@flovilmart flovilmart merged commit a6a6f7f into parse-community:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants