Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-32458) chore(pipeline): notify either it worked or failed #7030

Merged
merged 3 commits into from
Oct 17, 2024
Merged

(PC-32458) chore(pipeline): notify either it worked or failed #7030

merged 3 commits into from
Oct 17, 2024

Conversation

bebstein-pass
Copy link
Contributor

@bebstein-pass bebstein-pass commented Oct 16, 2024 •
edited
Loading

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32458

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

@bebstein-pass bebstein-pass changed the title wip (PC-32458) chore(pipeline): notift either it worked or failed Oct 16, 2024
@bebstein-pass bebstein-pass marked this pull request as ready for review October 16, 2024 14:02
@bebstein-pass bebstein-pass requested review from a team as code owners October 16, 2024 14:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Search Results - Performance test for Search Results page 13.5 ms → 14.1 ms (+0.6 ms, +4.4%) 5 → 5
Performance test for EndedBookings page 28.9 ms → 29.4 ms (+0.5 ms, +1.7%) 6 → 6
Performance test for Venue page 2.4 ms → 2.5 ms (+0.1 ms, +4.2%) 2 → 2
Performance test for Profile page 6.6 ms → 6.5 ms (-0.1 ms, -1.5%) 5 → 5
Search Landing Page - Performance test for Search Landing page 13.9 ms → 13.3 ms (-0.6 ms, -4.3%) 5 → 5
Performance test for Favorites page 62.6 ms → 61.3 ms (-1.3 ms, -2.1%) 6 → 6
Performance test for Bookings page 92.6 ms → 90.1 ms (-2.5 ms, -2.7%) 11 → 11
Performance test for Offer page 70.8 ms → 67.8 ms (-3.0 ms, -4.2%) 2 → 2
Show details
Name Render Duration Render Count
Search Results - Performance test for Search Results page Baseline
Mean: 13.5 ms
Stdev: 1.1 ms (8.0%)
Runs: 15 15 14 14 14 13 13 13 12 12

Current
Mean: 14.1 ms
Stdev: 1.2 ms (8.5%)
Runs: 16 15 15 15 14 14 14 13 13 12		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 28.9 ms
Stdev: 1.0 ms (3.4%)
Runs: 30 30 30 29 29 29 29 28 28 27

Current
Mean: 29.4 ms
Stdev: 2.5 ms (8.4%)
Runs: 33 32 32 30 30 29 28 28 26 26		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 2.4 ms
Stdev: 0.5 ms (21.5%)
Runs: 3 3 3 3 2 2 2 2 2 2

Current
Mean: 2.5 ms
Stdev: 0.5 ms (21.1%)
Runs: 3 3 3 3 3 2 2 2 2 2		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Profile page Baseline
Mean: 6.6 ms
Stdev: 1.3 ms (20.5%)
Runs: 9 8 7 7 7 6 6 6 6 4

Current
Mean: 6.5 ms
Stdev: 1.3 ms (19.5%)
Runs: 9 8 7 7 6 6 6 6 5 5		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 13.9 ms
Stdev: 1.7 ms (12.4%)
Runs: 16 16 16 15 14 13 13 12 12 12

Current
Mean: 13.3 ms
Stdev: 1.4 ms (10.7%)
Runs: 15 15 15 14 13 13 13 12 12 11		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 62.6 ms
Stdev: 2.5 ms (4.1%)
Runs: 67 66 64 63 63 62 61 61 60 59

Current
Mean: 61.3 ms
Stdev: 2.6 ms (4.2%)
Runs: 65 64 63 63 63 60 60 59 58 58		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 92.6 ms
Stdev: 3.2 ms (3.5%)
Runs: 97 97 95 93 92 92 92 91 91 86

Current
Mean: 90.1 ms
Stdev: 3.7 ms (4.1%)
Runs: 97 93 92 92 90 90 89 88 85 85		 Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for Offer page Baseline
Mean: 70.8 ms
Stdev: 2.1 ms (3.0%)
Runs: 74 74 72 72 70 70 70 70 68 68

Current
Mean: 67.8 ms
Stdev: 2.0 ms (2.9%)
Runs: 70 70 70 69 68 68 67 66 65 65		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against c02924d

@bebstein-pass bebstein-pass force-pushed the pipeline_must_not_lie branch 2 times, most recently from 0342e61 to 0adc76f Compare October 16, 2024 14:54
@bebstein-pass bebstein-pass changed the title (PC-32458) chore(pipeline): notift either it worked or failed (PC-32458) chore(pipeline): notify either it worked or failed Oct 16, 2024
tanguyprache
tanguyprache reviewed Oct 16, 2024
View reviewed changes
.github/workflows/dev_on_dispatch_create_and_push_ehp_deploy_tags.yml
@@ -1,4 +1,4 @@
name: "1 [on_dispatch][Jira] Create/Push ehp deploy tags"
name: '1 [on_dispatch][Jira] Create/Push ehp deploy tags'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semble qu'en YAML sauf certains cas particuliers (yes / no par exemple) on peut se passer des quotes. Donc pour moi on pourrait les supprimer carrément

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai la flemme de repasser sur tout les workflows à la main

c'était une modification automatique (voir premier commit)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui je comprends :)

@bebstein-pass
reformat workflows
222da53 
using this command:

```sh
prettier --write  .github/workflows/
```

VSCode does it when saving
@bebstein-pass
refactor: we only notify when tests fail, simplify the logic
8866aff
@bebstein-pass
notify on failure but also on success
c02924d 
@thconte because said :

> C'est hyper rassurant de savoir qu'un truc se déploie, quand on a un silence on a peur que la notification marche pas
https://passcultureteam.slack.com/archives/G01C85B6DHA/p1729085097420089?thread_ts=1729083568.986889&cid=G01C85B6DHA
@bebstein-pass bebstein-pass mentioned this pull request Oct 16, 2024
Draft
5 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bebstein-pass bebstein-pass merged commit 55bb986 into master Oct 17, 2024
51 checks passed
@bebstein-pass bebstein-pass deleted the pipeline_must_not_lie branch October 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanguyprache tanguyprache tanguyprache approved these changes

@mlachevre-pass mlachevre-pass mlachevre-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bebstein-pass @tanguyprache @mlachevre-pass