Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-???) refactor(pipeline): extract slack notification #7033

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

(PC-???) refactor(pipeline): extract slack notification #7033

wants to merge 10 commits into from

Conversation

bebstein-pass
Copy link
Contributor

@bebstein-pass bebstein-pass commented Oct 16, 2024 •
edited
Loading

en attente de #7030

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-XXXXX

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

@bebstein-pass
reformat workflows
68cca01 
using this command:

```sh
prettier --write  .github/workflows/
```

VSCode does it when saving
@bebstein-pass
refactor: we only notify when tests fail, simplify the logic
17c7658
@bebstein-pass
notify on failure but also on success
23840a4 
@thconte because said :

> C'est hyper rassurant de savoir qu'un truc se déploie, quand on a un silence on a peur que la notification marche pas
https://passcultureteam.slack.com/archives/G01C85B6DHA/p1729085097420089?thread_ts=1729083568.986889&cid=G01C85B6DHA
@bebstein-pass
add workflow to notify on slack
011f6b3
@bebstein-pass
refactor: use common slack notifier on android deploiement
3d62408
@bebstein-pass
refactor: use common workflow on iOS deploiement
c7cca1f
@bebstein-pass
refactor: use common slack notifier on CodePush deploiement
8b8e53e
@bebstein-pass
refactor: use common slack notifier in test
8648846 
replace `technote-space/workflow-conclusion-action@v3` which is archived with a ternary

the others jobs uses the outputs instead of env variable
@bebstein-pass
refactor: use common slack notifier on web deploiement
740c66e
@bebstein-pass
refactor: use common slack notifier on web proxy deploiement
926868d
@bebstein-pass
Copy link
Contributor Author

actuellement, le code qui envoie la notification slack est presque entièrement dupliqué d'un workflow à l'autre

cette branche permet d'extraire la notification slack dans son propre workflow

cette branche est en wip, car on atteint une limite et la pipeline échoue

peut etre que lorsqu'on sera passé à Github entreprise la limite sera plus élevée

@tanguyprache CI Guild, je vous donne cette branche, faites-en ce que vous voulez

@github-actions GitHub Actions
Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 95.2 ms → 96.8 ms (+1.6 ms, +1.7%) 11 → 11
Performance test for EndedBookings page 30.2 ms → 31.4 ms (+1.2 ms, +4.0%) 6 → 6
Performance test for Venue page 2.6 ms → 2.9 ms (+0.3 ms, +11.5%) 2 → 2
Search Landing Page - Performance test for Search Landing page 13.2 ms → 13.4 ms (+0.2 ms, +1.5%) 5 → 5
Performance test for Profile page 6.6 ms → 6.4 ms (-0.2 ms, -3.0%) 5 → 5
Search Results - Performance test for Search Results page 14.4 ms → 13.8 ms (-0.6 ms, -4.2%) 5 → 5
Performance test for Favorites page 65.3 ms → 64.2 ms (-1.1 ms, -1.7%) 6 → 6
Performance test for Offer page 71.8 ms → 70.3 ms (-1.5 ms, -2.1%) 2 → 2
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 95.2 ms
Stdev: 3.1 ms (3.2%)
Runs: 100 98 98 97 96 95 93 92 92 91

Current
Mean: 96.8 ms
Stdev: 3.1 ms (3.2%)
Runs: 102 101 98 98 97 96 96 94 93 93		 Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for EndedBookings page Baseline
Mean: 30.2 ms
Stdev: 2.2 ms (7.3%)
Runs: 34 33 31 31 31 29 29 29 28 27

Current
Mean: 31.4 ms
Stdev: 1.8 ms (5.9%)
Runs: 35 33 32 32 32 31 31 30 29 29		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 2.6 ms
Stdev: 0.8 ms (32.4%)
Runs: 4 4 3 3 2 2 2 2 2 2

Current
Mean: 2.9 ms
Stdev: 0.7 ms (25.4%)
Runs: 4 4 3 3 3 3 3 2 2 2		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 13.2 ms
Stdev: 1.5 ms (11.2%)
Runs: 15 14 14 14 14 14 13 12 12 10

Current
Mean: 13.4 ms
Stdev: 1.6 ms (12.3%)
Runs: 16 15 15 14 13 13 13 13 11 11		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 6.6 ms
Stdev: 1.1 ms (16.3%)
Runs: 8 8 7 7 7 7 6 6 5 5

Current
Mean: 6.4 ms
Stdev: 1.3 ms (19.8%)
Runs: 9 7 7 7 7 6 6 5 5 5		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Results - Performance test for Search Results page Baseline
Mean: 14.4 ms
Stdev: 1.4 ms (9.9%)
Runs: 16 15 15 15 15 15 15 14 13 11

Current
Mean: 13.8 ms
Stdev: 1.2 ms (8.9%)
Runs: 15 15 15 15 14 14 13 13 12 12		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 65.3 ms
Stdev: 2.9 ms (4.4%)
Runs: 69 68 67 67 66 65 65 64 63 59

Current
Mean: 64.2 ms
Stdev: 3.0 ms (4.7%)
Runs: 69 67 66 66 64 64 63 63 62 58		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Offer page Baseline
Mean: 71.8 ms
Stdev: 3.0 ms (4.1%)
Runs: 76 76 75 72 71 71 70 70 70 67

Current
Mean: 70.3 ms
Stdev: 1.6 ms (2.2%)
Runs: 73 72 71 71 71 70 69 69 69 68		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 926868d

@bebstein-pass
Copy link
Contributor Author

Github Enterprise ne changera rien

https://docs.github.com/en/enterprise-cloud@latest/actions/sharing-automations/reusing-workflows#limitations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bebstein-pass