Move VPNProtocolType serialization to Data layer #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
force-pushed
the
refactoring/vpn-protocol-serialization
branch
from
20796ed
to
4158c68
Compare
keeshux
added a commit
that referenced
this pull request
Jul 3, 2023
Reverts #318 `Codable` compliance at the domain layer (`Profile` etc.) makes this change in serialization destructive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's crucial that the data layer has full control over how entities are (de)serialized.
Do not leave this choice up to the domain layer by defining an enum as a raw value type, because any change in the enum raw value would literally be a disaster, i.e. any serialized data would break instantly.