Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move VPNProtocolType serialization to Data layer" #319

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Jul 3, 2023

Reverts #318

Codable compliance at the domain layer (Profile etc.) makes this change in serialization destructive.

@keeshux keeshux added bug Something isn't working refactoring Improves software architecture labels Jul 3, 2023
@keeshux keeshux added this to the 2.2.0 milestone Jul 3, 2023
@keeshux keeshux self-assigned this Jul 3, 2023
@keeshux keeshux added the regression Used to work but doesn't anymore label Jul 3, 2023
@keeshux keeshux merged commit e960943 into master Jul 3, 2023
1 check passed
@keeshux keeshux deleted the revert-318-refactoring/vpn-protocol-serialization branch July 3, 2023 09:18
@keeshux keeshux removed the bug Something isn't working label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improves software architecture regression Used to work but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant