Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Option for Requests #91

Closed
MWandtke opened this issue Jan 26, 2018 · 9 comments
Closed

Proxy Option for Requests #91

MWandtke opened this issue Jan 26, 2018 · 9 comments

Comments

@MWandtke
Copy link

Hey,

sometimes when you are behind a company proxy you will need the proxy option of request.
Is it possible, that you can provide this?

Thanks

@pat310
Copy link
Owner

pat310 commented Jan 27, 2018

hi @MWandtke yea I can provide that. There is a PR open for proxy right now. I was planning to change it so the user can select what proxy library they want to use to increase flexibility and remove the dependency. I'll circle back once that is done but if you need something right away, you should use what has been done in that branch.

@MWandtke
Copy link
Author

nice. thanks man. sorry that I didn't see that PR

@pat310
Copy link
Owner

pat310 commented Jan 27, 2018

no worries 😃

@aaronmefford
Copy link

Just submitted a PR that will allow selecting a proxy library.

@pat310
Copy link
Owner

pat310 commented Feb 1, 2018

Thanks @aaronmefford! Going to cut a new version 4.5.0

@pat310 pat310 closed this as completed Feb 1, 2018
@ishtartec
Copy link

@pat310, the published version (4.5.0) in the npm repository is using and old google-trends-api.js in the lib directory that is not including the proxy changes. Proxying seems broken right now.

@pat310
Copy link
Owner

pat310 commented Feb 19, 2018

Thanks mate @ishtartec! Just a cut a new version (4.6.0) for some other changes. Should have a new file in the lib directory now.

@ishtartec
Copy link

@pat310, I've created PR #95. The proxy support was broken. It was missing adding the proxy agent options to the nextRequest object.
I've tested on a fully proxied environment and it works now.

@pat310
Copy link
Owner

pat310 commented Feb 22, 2018

👍 👍 closed in #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants