UIKit Refactor Part 7: Modal Refactor #960
Conversation
…all PL layout, cross browser fixes and scrolling improvements. add prettier and prettier-quick dev-dependencies to always run, even when not globally available
…ver as a new Preact component.
…s to know if you can scroll and if so, in what direction
…he latest refactored component Sass + legacy partials in alphabetical order
|
At least this CI failure is more straightforward |
|
@bmuenzenmeyer lol - meanwhile, I was arguing with myself... "crap - should I toss these eslint / prettier fixes in, even though I wasn't working on those files..."
|
|
@bmuenzenmeyer PR description updated |
# Conflicts: # packages/uikit-workshop/dist/styleguide/js/patternlab-viewer.js # packages/uikit-workshop/package.json # packages/uikit-workshop/src/scripts/utils/polyfills.js
sghoweri
changed the title
|
@sghoweri this is the last PR! let me know when ready for review |
# Conflicts: # packages/uikit-workshop/dist/index.html # packages/uikit-workshop/dist/styleguide/css/pattern-lab.css # packages/uikit-workshop/dist/styleguide/js/patternlab-pattern.js # packages/uikit-workshop/dist/styleguide/js/patternlab-viewer.js # packages/uikit-workshop/package.json # packages/uikit-workshop/src/html/index.html # packages/uikit-workshop/src/html/partials/modal.html # packages/uikit-workshop/src/sass/pattern-lab.scss # packages/uikit-workshop/src/sass/scss/04-components/_header.scss # packages/uikit-workshop/src/sass/scss/04-components/_navigation.scss # packages/uikit-workshop/src/sass/scss/04-components/_pattern-info.scss # packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss # packages/uikit-workshop/src/sass/scss/04-components/_viewport.scss # packages/uikit-workshop/src/sass/scss/05-themes/_light-theme.scss # packages/uikit-workshop/src/scripts/components/pl-drawer/pl-drawer.scss # packages/uikit-workshop/src/scripts/components/pl-layout/pl-layout.scss # packages/uikit-workshop/src/scripts/components/pl-search/pl-search.scss # packages/uikit-workshop/src/scripts/patternlab-pattern.js
…rawer> component; add new UIKit build
@bmuenzenmeyer I just finished pushing up a couple small small fixes after merging in the latest from dev -- should be all set to review! |
@bmuenzenmeyer yeah, I noticed that the viewall page’s info / code panels weren’t opening — either directly or indirectly related to some Pattern-specific JSON data that appears to be missing from the generated HTML... I definitely want to make sure we double-check that the accordion-like functionality still works as expected on the viewall pages with these updates here. I know the original version of this PR worked as expected in PL PHP — (at least I know it did before I made a couple updates after further testing this out in the Handlebars demo, so I’ll double check that 😉). I suspect the missing viewall page’s JSON data and #890 are likely related and need to get fixed in order to get this on PR wrapped up. |
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
|
What's the status of this guy? Just trying to keep stalebot at bay. |
…uikit-refactor-p7 # Conflicts: # packages/uikit-workshop/package.json
…uikit-refactor-p7 # Conflicts: # packages/uikit-workshop/dist/styleguide/css/pattern-lab.css # packages/uikit-workshop/dist/styleguide/js/patternlab-pattern.js # packages/uikit-workshop/dist/styleguide/js/patternlab-viewer.js
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
|
Bump. Still open. I owe @bradfrost some PR review info to get this ball rolling again. |
… refactor work that builds off of the updates from pattern-lab#960 and pattern-lab#973
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
|
@sghoweri is this ready for review? |
@bmuenzenmeyer besides resolving the merge conflicts, yeah, I think this is still ready to go. Definitely would be nice to see the light at the end of the tunnel with this one, #973 and #1008, since that's pretty darn close to where our UIKit implementation is currently at: https://boltdesignsystem.com/pattern-lab/?p=components-overview |
|
This comment is still relevant - opening an issue for that |
… refactor work that builds off of the updates from pattern-lab#960 and pattern-lab#973
Summary
1st round refactor of Pattern Lab's modal / drawer UI.
Link to our Pattern Lab instance with these latest UIKit improvements:
https://uikit-refactor-p7.now.sh/pattern-lab/index.html
Before (left) and After (right)
Enhancements
Refactor "Modal" UI; ports to new
<pl-drawer>component<pl-drawer>web component (uses the same Preact-powered base component used in UIKit Refactor Part 5: Redux + SkateJS + Preact-Powered Web Components #946 and UIKit Refactor Part 6: Refactor Search / Typeahead Component, Bug Fixes, and Improved Scrolling #949)Add New
<pl-toggle-info>component<pl-toggle-info>component that's toggles the drawer's state + automatically updates behavior when on viewall pages