Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKit Refactor Part 7: Modal Refactor #960

Merged
merged 17 commits into from
Jul 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lerna": "3.2.1",
"lerna": "3.10.8",
"packages": [
"packages/*"
],
Expand Down
10 changes: 6 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
{
"devDependencies": {
"lerna": "3.2.1"
"dependencies": {
"lerna": "3.10.8",
"prettier": "^1.14.3",
"pretty-quick": "^1.8.0"
},
"private": true,
"scripts": {
"bootstrap": "lerna bootstrap",
"setup": "npm run bootstrap && npm run build:uikit",
"build:uikit": "lerna exec --scope @pattern-lab/uikit-workshop -- npm run build",
"setup": "npm install && npm run bootstrap && npm run build:uikit",
"build:uikit": "cd packages/uikit-workshop && npm run build",
"precommit": "pretty-quick --staged",
"prettier": "prettier --config .prettierrc --write ./**/*.js --ignore-path .prettierignore",
"test": "lerna run test",
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/lib/addPattern.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
'use strict';

const _ = require('lodash');

const logger = require('./log');

module.exports = function(pattern, patternlab) {
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/lib/buildPatterns.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,10 @@ module.exports = (deletePatternDir, patternlab, additionalData) => {
}
//render all patterns last, so lineageR works
const allPatternsPromise = patternsToBuild.map(pattern =>
compose(pattern, patternlab)
compose(
pattern,
patternlab
)
);
//copy non-pattern files like JavaScript
const allJS = patternsToBuild.map(pattern => {
Expand Down
6 changes: 2 additions & 4 deletions packages/core/src/lib/markModifiedPatterns.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ module.exports = function(lastModified, patternlab) {
array.forEach(func);
}
};
const modifiedOrNot = _.groupBy(
patternlab.patterns,
p =>
changes_hunter.needsRebuild(lastModified, p) ? 'modified' : 'notModified'
const modifiedOrNot = _.groupBy(patternlab.patterns, p =>
changes_hunter.needsRebuild(lastModified, p) ? 'modified' : 'notModified'
);

// For all unmodified patterns load their rendered template output
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/lib/object_factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ const Pattern = function(relPath, data, patternlab) {
// (rendered!) html file for this pattern, to be shown in the iframe
this.patternLink = this.patternSectionSubtype
? `$${this.name}/index.html`
: patternlab ? this.getPatternLink(patternlab, 'rendered') : null;
: patternlab
? this.getPatternLink(patternlab, 'rendered')
: null;

// The canonical "key" by which this pattern is known. This is the callable
// name of the pattern. UPDATE: this.key is now known as this.patternPartial
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/lib/plugin_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
const plugin_manager = function() {
const path = require('path');
const findModules = require('./findModules');

const _ = require('lodash');

const logger = require('./log');

const pluginMatcher = /^plugin-(.*)$/;
Expand Down
26 changes: 2 additions & 24 deletions packages/uikit-workshop/dist/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -77,27 +77,7 @@

</div>
<!--end pl-c-viewport-->
<div class="pl-c-modal__cover pl-js-modal-cover"></div>
<div class="pl-c-modal pl-js-modal">
<div class="pl-c-modal__toolbar">
<div class="pl-c-modal__resizer pl-js-modal-resizer"></div>
<div class="pl-c-modal__toolbar-controls">
<!-- @todo: revisit to see if slotted content might make sense here (ex. to have an extra toggle for switching the layout -->
<pl-toggle-layout></pl-toggle-layout>

<button class="pl-c-modal__close-btn pl-js-modal-close-btn" title="Hide pattern info">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="12" height="12" viewBox="0 0 12 12" class="pl-c-modal__close-btn-icon">
<title>Close</title>
<path fill="currentColor" d="M11.8905,9.6405 L11.8905,9.6405 L8.25,6 L11.8905,2.3595 L11.8905,2.3595 C11.9295,2.3205 11.958,2.27475 11.976,2.226 C12.0255,2.0925 11.997,1.9365 11.8905,1.82925 L10.17075,0.1095 C10.0635,0.00225 9.9075,-0.02625 9.774,0.024 C9.72525,0.042 9.6795,0.0705 9.6405,0.1095 L9.6405,0.1095 L6,3.75 L2.3595,0.1095 L2.3595,0.1095 C2.3205,0.0705 2.27475,0.042 2.226,0.024 C2.0925,-0.0255 1.9365,0.00225 1.82925,0.1095 L0.1095,1.82925 C0.00225,1.9365 -0.02625,2.0925 0.024,2.226 C0.042,2.27475 0.0705,2.3205 0.1095,2.3595 L0.1095,2.3595 L3.75,6 L0.1095,9.6405 L0.1095,9.6405 C0.0705,9.6795 0.042,9.72525 0.024,9.774 C-0.0255,9.9075 0.00225,10.0635 0.1095,10.17075 L1.82925,11.8905 C1.9365,11.99775 2.0925,12.02625 2.226,11.976 C2.27475,11.958 2.3205,11.9295 2.3595,11.8905 L2.3595,11.8905 L6,8.25 L9.6405,11.8905 L9.6405,11.8905 C9.6795,11.9295 9.72525,11.958 9.774,11.976 C9.9075,12.0255 10.0635,11.99775 10.17075,11.8905 L11.8905,10.17075 C11.99775,10.0635 12.02625,9.9075 11.976,9.774 C11.958,9.72525 11.9295,9.6795 11.8905,9.6405 L11.8905,9.6405 Z"></path>
</svg>
</button>
</div>
</div>
<div class="pl-c-modal__content-wrapper">
<div class="pl-c-modal__content pl-js-modal-content"></div>
</div>
</div>

<pl-drawer></pl-drawer>
</div>
</pl-layout>

Expand Down Expand Up @@ -229,9 +209,7 @@

<ul class="pl-c-tools__list pl-js-acc-panel">
<li class="pl-c-tools__item">
<button class="pl-c-tools__action pl-js-pattern-info-toggle">Show Pattern Info</button>
<!-- WIP - commenting out for now -->
<!-- <pl-info-toggle></pl-info-toggle> -->
<pl-toggle-info></pl-toggle-info>
</li>
<li class="pl-c-tools__item">
<pl-toggle-layout text="Switch Layout"><pl-toggle-layout>
Expand Down

Large diffs are not rendered by default.

This file was deleted.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

1,516 changes: 103 additions & 1,413 deletions packages/uikit-workshop/dist/styleguide/js/patternlab-viewer.js

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading