feat(SimpleFileUpload): consumed Penta updates #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
commented
Jan 19, 2024
| value={filename} | ||
| /> | ||
| </InputGroupItem> | ||
| <InputGroupItem> | ||
| <Button | ||
| id={`${id}-browse-button`} |
There was a problem hiding this comment.
We could keep this in, but if we're going to expose an ID on the browse button then we should consider allowing an ID to be passed to all other input elements within the component. For now I included this in the codemod issue patternfly/pf-codemods#551
thatblindgeye
requested review from
a team,
wise-king-sullyman,
nicolethoen,
andrew-ronaldson,
lboehling and
mattnolting
and removed request for
a team
|
Preview: https://patternfly-react-pr-10026.surge.sh A11y report: https://patternfly-react-pr-10026-a11y.surge.sh |
nicolethoen
reviewed
Jan 22, 2024
|
@nicolethoen good point. I updated codemod patternfly/pf-codemods#551 to mention providing a warning that consumers should use the new FileUploadHelperText sub-component (right now we only have examples that show using a FormHelperText as a separate piece). |
nicolethoen
approved these changes
Jan 30, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9996
codemod: patternfly/pf-codemods#551
Additional issues: