Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple file upload - Penta updates #551

Closed
thatblindgeye opened this issue Jan 19, 2024 · 0 comments · Fixed by #570
Closed

Simple file upload - Penta updates #551

thatblindgeye opened this issue Jan 19, 2024 · 0 comments · Fixed by #570
Assignees
@thatblindgeye
Labels
codemod
Milestone
Penta alpha release

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Jan 19, 2024 •
edited
Loading

Follow up to breaking change PR:

  • feat(SimpleFileUpload): consumed Penta updates patternfly-react#10026
    • removed the aria-describedby from the TextInput component
    • removed the id attribute from the browse button (was only being used for the above aria-describedby
    • example(s) using FormHelperText now just use FileUploadHelperText as a container (provide a warning that consumers should make this update)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 19, 2024
@thatblindgeye thatblindgeye mentioned this issue Jan 19, 2024
Merged
@tlabaj tlabaj added the codemod label Feb 14, 2024
@tlabaj tlabaj added this to the Penta alpha release milestone Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Not started in PatternFly Issues Feb 14, 2024
@thatblindgeye thatblindgeye self-assigned this Feb 15, 2024
@thatblindgeye thatblindgeye mentioned this issue Feb 19, 2024
Merged
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Feb 19, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(SimpleFileUpload): added rule to warn about component changes thatblindgeye/pf-codemods
2 participants
@tlabaj @thatblindgeye