Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimpleFileUpload): added rule to warn about component changes #570

Merged

Conversation

thatblindgeye
Copy link
Collaborator

Closes #551

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, not blocking though.

@@ -0,0 +1,2 @@
import { SimpleFileUpload } from "@patternfly/react-core";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the input and output files?

@wise-king-sullyman wise-king-sullyman merged commit fa19da5 into patternfly:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple file upload - Penta updates
2 participants