Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for Issue 253 & Updated libphonenumber to 8.10.2 #254

Merged
merged 4 commits into from
Jan 5, 2019

Conversation

superhit0
Copy link
Collaborator

@superhit0 superhit0 commented Jan 2, 2019

@superhit0
Copy link
Collaborator Author

@patw0929 can you upgrade the version of libphonenumber to 8.10.2

Then I will push yarn.lock & package-lock as well.

@patw0929
Copy link
Owner

patw0929 commented Jan 3, 2019

I still meet the issue of #253 (window is not defined) with this PR.

@patw0929
Copy link
Owner

patw0929 commented Jan 3, 2019

Oh, by the way, I had already published libphonenumber-js-utils to v8.10.2.

@coveralls
Copy link

coveralls commented Jan 4, 2019

Coverage Status

Coverage remained the same at 94.027% when pulling 8405de5 on superhit0:issue-253 into 55a07cd on patw0929:master.

@superhit0
Copy link
Collaborator Author

@patw0929 can you check now?

There was a silly mistake that I made :P.

I am not completely proud of the solution but its verbose.

what do you say?

@patw0929
Copy link
Owner

patw0929 commented Jan 4, 2019

It works!

Screenshot:

next.config.js

const withCSS = require('@zeit/next-css');

module.exports = withCSS({
  webpack: function (config) {
    config.module.rules.push({
      test: /\.(png|jpg|gif)$/,
      use: {
        loader: 'file-loader',
        options: {
          publicPath: '../../static/',
          outputPath: './static/',
        },
      }
    })
    return config
  }
});

attempt-to-import.js

import { Fragment } from 'react';
import IntlTelInput from 'react-intl-tel-input';
import style from 'react-intl-tel-input/dist/main.css';

export default () => (
  <Fragment>
    <style dangerouslySetInnerHTML={{ __html: style }} />
    <IntlTelInput />
  </Fragment>
);

@patw0929
Copy link
Owner

patw0929 commented Jan 4, 2019

@superhit0 Could you update yarn.lock?
Thanks!

@superhit0
Copy link
Collaborator Author

@patw0929 updated yarn.lock

@patw0929 patw0929 merged commit 0b61bf7 into patw0929:master Jan 5, 2019
patw0929 added a commit that referenced this pull request Jan 5, 2019
New features:

* #249: Add support for onFlagClick (by @tomegz)
* #254: Updated libphonenumber-js-utils to v8.10.2

Bug fixes:

* #254: Fixed #253 Can not import from Node.js since module build upgrade to webpack 4
* Use another geoip service in example page (avoid adblock issue)
* Show logger on example page
patw0929 added a commit that referenced this pull request Jan 8, 2019
New features

- #249: Add support for onFlagClick (by @tomegz)
- #254: Updated libphonenumber to 8.10.2 (by @superhit0)
- #256: Added event object to onPhoneNumberBlur callback's parameter (by @superhit0)

Bug fixes

- #254: Fixed issue #253 - Can not import from Node.js since module build upgrade to webpack 4 (by @superhit0)
- #256: Defined .npmrc to avoid overriding the default npm registry server (by @superhit0)
- #259: Fixed not update value issue when value is empty string (by @patw0929)
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Added fix for Issue 253 & Updated libphonenumber to 8.10.2
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
New features:

* patw0929#249: Add support for onFlagClick (by @tomegz)
* patw0929#254: Updated libphonenumber-js-utils to v8.10.2

Bug fixes:

* patw0929#254: Fixed patw0929#253 Can not import from Node.js since module build upgrade to webpack 4
* Use another geoip service in example page (avoid adblock issue)
* Show logger on example page
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
New features

- patw0929#249: Add support for onFlagClick (by @tomegz)
- patw0929#254: Updated libphonenumber to 8.10.2 (by @superhit0)
- patw0929#256: Added event object to onPhoneNumberBlur callback's parameter (by @superhit0)

Bug fixes

- patw0929#254: Fixed issue patw0929#253 - Can not import from Node.js since module build upgrade to webpack 4 (by @superhit0)
- patw0929#256: Defined .npmrc to avoid overriding the default npm registry server (by @superhit0)
- patw0929#259: Fixed not update value issue when value is empty string (by @patw0929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants