Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not update value issue when value is empty string #259

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

patw0929
Copy link
Owner

@patw0929 patw0929 commented Jan 7, 2019

Fixed the issue of not updating value when value is empty string.

  1. We should let empty value also can be updated in getDerivedStateFromProps.
  2. No need to setState in blurHandler event in example.

Before


After

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.027% when pulling b9703db on fix/not-update-value-when-empty into dd2faf1 on master.

Copy link
Collaborator

@superhit0 superhit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patw0929 patw0929 merged commit b569e98 into master Jan 8, 2019
patw0929 added a commit that referenced this pull request Jan 8, 2019
New features

- #249: Add support for onFlagClick (by @tomegz)
- #254: Updated libphonenumber to 8.10.2 (by @superhit0)
- #256: Added event object to onPhoneNumberBlur callback's parameter (by @superhit0)

Bug fixes

- #254: Fixed issue #253 - Can not import from Node.js since module build upgrade to webpack 4 (by @superhit0)
- #256: Defined .npmrc to avoid overriding the default npm registry server (by @superhit0)
- #259: Fixed not update value issue when value is empty string (by @patw0929)
@patw0929 patw0929 deleted the fix/not-update-value-when-empty branch February 12, 2019 02:46
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
…en-empty

Fixed not update value issue when value is empty string
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
New features

- patw0929#249: Add support for onFlagClick (by @tomegz)
- patw0929#254: Updated libphonenumber to 8.10.2 (by @superhit0)
- patw0929#256: Added event object to onPhoneNumberBlur callback's parameter (by @superhit0)

Bug fixes

- patw0929#254: Fixed issue patw0929#253 - Can not import from Node.js since module build upgrade to webpack 4 (by @superhit0)
- patw0929#256: Defined .npmrc to avoid overriding the default npm registry server (by @superhit0)
- patw0929#259: Fixed not update value issue when value is empty string (by @patw0929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants