Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cursor position after focused #265

Merged
merged 2 commits into from
Jan 25, 2019
Merged

update cursor position after focused #265

merged 2 commits into from
Jan 25, 2019

Conversation

Loongwoo
Copy link
Contributor

This commit fixed an issue like this. There are two Inputs in a form on my login page. The phone number input will get focus after entering every one character in password input. Because the form managed the inputs together.

@patw0929
Copy link
Owner

@Loongwoo Thank you for your contribution!
I think this PR might fix #266 too.

I've made some review, please help to fix it and make the CI test pass too. 👍

@Loongwoo
Copy link
Contributor Author

Thanks for your review. I have fix the issues as you said.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 94.078% when pulling a956741 on Loongwoo:master into ea768de on patw0929:master.

@patw0929 patw0929 merged commit de43b85 into patw0929:master Jan 25, 2019
patw0929 added a commit that referenced this pull request Jan 25, 2019
@patw0929
Bumped version into v6.1.1
ea1c29f 
Bug fixes

- #269: Fixed issue #268 - disabled state doesn't update an input field (by @patw0929)
- #265: update cursor position after focused (by @Loongwoo)

Chores

- #267 - Use createPortal API to implement RootModal (by @patw0929)
- Added ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Merge pull request patw0929#265 from Loongwoo/master
69f1bb9 
update cursor position after focused
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Bumped version into v6.1.1
b166185 
Bug fixes

- patw0929#269: Fixed issue patw0929#268 - disabled state doesn't update an input field (by @patw0929)
- patw0929#265: update cursor position after focused (by @Loongwoo)

Chores

- patw0929#267 - Use createPortal API to implement RootModal (by @patw0929)
- Added ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patw0929 patw0929 patw0929 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Loongwoo @patw0929 @coveralls