Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use createPortal API to implement RootModal #267

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Use createPortal API to implement RootModal #267

merged 1 commit into from
Jan 25, 2019

Conversation

patw0929
Copy link
Owner

We should use createPortal API which provide by React to implement the mobile flag modal feature instead.

Reference: https://reactjs.org/docs/portals.html

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 93.986% when pulling b05cc98 on feature/use-create-portal into ea768de on master.

@patw0929 patw0929 merged commit b21a5f9 into master Jan 25, 2019
@patw0929 patw0929 deleted the feature/use-create-portal branch January 25, 2019 02:54
patw0929 added a commit that referenced this pull request Jan 25, 2019
@patw0929
Bumped version into v6.1.1
ea1c29f 
Bug fixes

- #269: Fixed issue #268 - disabled state doesn't update an input field (by @patw0929)
- #265: update cursor position after focused (by @Loongwoo)

Chores

- #267 - Use createPortal API to implement RootModal (by @patw0929)
- Added ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Merge pull request patw0929#267 from patw0929/feature/use-create-portal
c5b7839 
Use createPortal API to implement RootModal
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Bumped version into v6.1.1
b166185 
Bug fixes

- patw0929#269: Fixed issue patw0929#268 - disabled state doesn't update an input field (by @patw0929)
- patw0929#265: update cursor position after focused (by @Loongwoo)

Chores

- patw0929#267 - Use createPortal API to implement RootModal (by @patw0929)
- Added ISSUE_TEMPLATE.md & PULL_REQUEST_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patw0929 @coveralls