Fix: storybook's public path #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patw0929
added a commit
that referenced
this pull request
Feb 14, 2019
Bug fixes: - #277: Fix(272): Updating Allowdropdown after mount Docs: - #273: Feature: Introducing storybook for documentation and playground - #274: fix(storybook-deploy): Fixed the storybook deployment script in travis - #275: Fix: storybook's public path - #276: Refactor: Removing all unused files and codes for example
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
Fix: storybook's public path
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
Bug fixes: - patw0929#277: Fix(272): Updating Allowdropdown after mount Docs: - patw0929#273: Feature: Introducing storybook for documentation and playground - patw0929#274: fix(storybook-deploy): Fixed the storybook deployment script in travis - patw0929#275: Fix: storybook's public path - patw0929#276: Refactor: Removing all unused files and codes for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the public path of storybook's file loader.
When we've deployed storybook build files to github pages, we would found that the flags image were missing.
That's because the storybook's webpack file-loader public path setting is set to
'/', and the github page of this repo has its subfolder/react-intl-tel-input/.It should be relative path
'./'here.Screenshots (if appropriate):
Types of changes
Checklist: