Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Removing all unused files and codes for example #276

Merged
merged 5 commits into from
Feb 14, 2019

Conversation

nutboltu
Copy link
Collaborator

Description

As we are using storybook, it's time to clean up all dead codes related to example
This PR removed all the files and codes that used for example and also clear the build process process for example.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nutboltu nutboltu self-assigned this Feb 12, 2019
@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging e018409 into b01621f - view on LGTM.com

fixed alerts:

  • 1 for Incomplete URL substring sanitization

Comment posted by LGTM.com

@coveralls
Copy link

coveralls commented Feb 12, 2019

Coverage Status

Coverage remained the same at 93.401% when pulling 8554791 on fix/example-cleanup into b01621f on master.

Copy link
Owner

@patw0929 patw0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove example/report.html in .gitignore.

@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging 8554791 into b01621f - view on LGTM.com

fixed alerts:

  • 1 for Incomplete URL substring sanitization

Comment posted by LGTM.com

@patw0929 patw0929 merged commit fc858e7 into master Feb 14, 2019
@patw0929 patw0929 deleted the fix/example-cleanup branch February 14, 2019 15:23
patw0929 added a commit that referenced this pull request Feb 14, 2019
Bug fixes:

- #277: Fix(272): Updating Allowdropdown after mount

Docs:

- #273: Feature: Introducing storybook for documentation and playground
- #274: fix(storybook-deploy): Fixed the storybook deployment script in travis
- #275: Fix: storybook's public path
- #276: Refactor: Removing all unused files and codes for example
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Refactor: Removing all unused files and codes for example
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Bug fixes:

- patw0929#277: Fix(272): Updating Allowdropdown after mount

Docs:

- patw0929#273: Feature: Introducing storybook for documentation and playground
- patw0929#274: fix(storybook-deploy): Fixed the storybook deployment script in travis
- patw0929#275: Fix: storybook's public path
- patw0929#276: Refactor: Removing all unused files and codes for example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants